Remove new link styles feature flag #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the CSS within the block guarded by the new link styles flag is also guarded by the other settings. This means we can remove the flag as users can still disable the new link styles by setting: ``` $govuk-link-underline-offset: false; $govuk-link-underline-thickness: false; $govuk-link-hover-underline-thickness: false; ```
owenatgov
dismissed
their stale review
I'm removing this as I was too keen and missed that this was still in draft
colinrotherham
approved these changes
May 11, 2023
romaricpascal
pushed a commit
that referenced
this pull request
May 18, 2023
Remove new link styles feature flag
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from #3599 and removes the feature flag entirely. I think this makes sense as all of the CSS within the block guarded by the new link styles flag is also guarded by the other settings.
This means we can remove the flag as users can still disable the new link styles by setting:
Would appreciate second opinions on whether this makes sense or whether we should do it 'properly' and deprecate it and remove it in v6 instead.