Remove $govuk-typography-use-rem setting
#3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like some output tests need updating to account for the px values no longer being returned outside of print styles, but otherwise LGTM 👍 |
owenatgov
force-pushed
the
remove-typography-use-rem-setting
branch
from
a98d892
to
794ccf8
Compare
querkmachine
approved these changes
May 4, 2023
romaricpascal
pushed a commit
that referenced
this pull request
May 18, 2023
Remove `$govuk-typography-use-rem` setting
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
Removes all internal references to
$govuk-typography-use-rem, references to it in internal documentation, tests that reference it and cover it and the setting itself.Resolves #2790