Remove unused console.log calls from accordion JavaScript
#2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2766
owenatgov
approved these changes
Aug 15, 2022
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2766
Because of the way the if statements are written, these attempts to call `console.log` and `console.error` will only ever run if either `console` or `console.log` is undefined (and therfore _not_ a function). They will never successfully write anything to the console log. Given that they’ve been like this for several years (since 027373d), we can safely assume they’re not doing anything useful, and can remove them.
36degrees
force-pushed
the
accordion-console-logs
branch
from
5826093
to
615adc1
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2766
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way the if statements are written, these attempts to call
console.logandconsole.errorwill only ever run if eitherconsoleorconsole.logis undefined (and therfore not a function). They will never successfully write anything to the console log.Given that they’ve been like this for several years (since 027373d), we can safely assume they’re not doing anything useful, and can remove them.