Skip to content

Commit

Permalink
Always run postbuild scripts
Browse files Browse the repository at this point in the history
Since we no longer build JSDoc, SassDoc or stats via Gulp we can turn these back on
  • Loading branch information
colinrotherham committed Sep 21, 2023
1 parent 4314e8e commit 18267fc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,5 @@ runs:
if: steps.build-cache.outputs.cache-hit != 'true'
shell: bash

# Build all workspaces but skip `postbuild` scripts
# since we run these in other workflow steps instead
run: npm run build --workspaces --if-present --ignore-scripts
# Build all workspaces
run: npm run build --workspaces --if-present
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,11 @@ jobs:
task:
- description: Verify package build
name: test-build-package
run: npm run build:package -- --ignore-scripts
run: npm run build:package

- description: Verify distribution build
name: test-build-release
run: npm run build:release -- --ignore-scripts
run: npm run build:release

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"build:types": "npm run build:types --workspaces --if-present",
"postbuild:package": "jest --color --selectProjects \"Build tasks\" --testMatch \"**/build/package.unit.test.mjs\"",
"postbuild:release": "jest --color --selectProjects \"Build tasks\" --testMatch \"**/build/release.unit.test.mjs\"",
"heroku-postbuild": "npm run build -- --ignore-scripts",
"heroku-postbuild": "npm run build",
"postheroku-postbuild": "NPM_CONFIG_PRODUCTION=true npm ci --ignore-scripts --omit=optional --workspace @govuk-frontend/review",
"pretest": "npm run build",
"test": "jest --color --ignoreProjects \"Build tasks\" --maxWorkers=50%",
Expand Down

0 comments on commit 18267fc

Please sign in to comment.