Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.61 #10

Merged
merged 40 commits into from
Feb 28, 2024
Merged

Version 0.61 #10

merged 40 commits into from
Feb 28, 2024

Conversation

ashesfall
Copy link
Collaborator

No description provided.

…ailable, most notably at the time of creating a Variable, ArrayVariable, etc. Some other cleanup, including progress toward the elimination of NameProvider and KernelSupport. Improvements to PairBankFromPairsBuilder and ComplexNumber, along with a new test of complex multiplication.
…ew features of Scope and Cases including the option to have arbitrary Variable parameters beyond those ArrayVariables that are inferred from usage. Introduced ArrayDeclaration, a Statement implementation that declares a value without assignment (which declaration through ExpressionAssignment can't easily be made to do). Introduced FourierTransform, and corresponding tests, though this is still very much a work in progress.
…introduced new TimeCell::frame that provides a single value.
… Updated Loop to use Repeated Scope implementation. CollectionProducerComputationBase is updated to accept a name argument. Removed unnecessary warning from InstanceReference. Updates to IndexProjectionProducerComputation and CollectionFeatures in an attempt to improve the implementation of CollectionFeatures::max using CollectionFeatures::indexOfMax.
…ow successfully used to implement CollectionFeatures::max. This does break some uses of PackedCollectionMap, but they can be easily replaced now that CollectionFeatures::max is more flexible. Fix for defect in Scope due to missing equals/hashcode. Updates to tests, and to github pipeline test configuration.
…a reference to another HardwareEvaluable instance. Protection against the same in DestinationEvaluable constructor. Warning in CodeFeatures::v. Updated error handling in TraversalPolicy::getCount.
…prove efficiency of some types of Mod operations. Introduced save and restore operations for TraversalPolicy and PackedCollection. Test updates.
Copy link

github-actions bot commented Feb 27, 2024

Qodana for JVM

681 new problems were found

Inspection name Severity Problems
Unused import 🔶 Warning 191
Redundant 'Collection.addAll()' call 🔶 Warning 126
Type parameter hides visible type 🔶 Warning 48
Constant values 🔶 Warning 38
Pointless boolean expression 🔶 Warning 36
Unused assignment 🔶 Warning 24
'*' import 🔶 Warning 18
Optional.get() is called without isPresent() check 🔶 Warning 16
Nullability and data flow problems 🔶 Warning 15
Manual array copy 🔶 Warning 13
Redundant 'if' statement 🔶 Warning 11
Bulk operation can be used instead of iteration 🔶 Warning 11
Redundant array creation 🔶 Warning 10
Result of method call ignored 🔶 Warning 9
'Optional' used as field or parameter type 🔶 Warning 9
Method does not call super method 🔶 Warning 7
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 7
AutoCloseable used without 'try'-with-resources 🔶 Warning 6
Catch block may ignore exception 🔶 Warning 6
Manual array to collection copy 🔶 Warning 6
Confusing argument to varargs method 🔶 Warning 6
Suspicious collection method call 🔶 Warning 6
Busy wait 🔶 Warning 5
Suspicious 'Collection.toArray()' call 🔶 Warning 5
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 4
Boolean constructor call 🔶 Warning 3
Suspicious 'Comparator.compare()' implementation 🔶 Warning 3
Inner class may be 'static' 🔶 Warning 3
Pointless arithmetic expression 🔶 Warning 3
Statement with empty body 🔶 Warning 2
Infinite loop statement 🔶 Warning 2
Mismatched read and write of array 🔶 Warning 2
Mismatched query and update of collection 🔶 Warning 2
Synchronization on a non-final field 🔶 Warning 2
Wrapper type may be primitive 🔶 Warning 2
Number constructor call with primitive argument 🔶 Warning 1
Cloneable class without 'clone()' method 🔶 Warning 1
Contract issues 🔶 Warning 1
Copy constructor misses field 🔶 Warning 1
'equals()' method which does not check class of parameter 🔶 Warning 1
'finalize()' should be protected, not public 🔶 Warning 1
Kotlin Maven Plugin misconfigured 🔶 Warning 1
kotlin-test-junit could be used 🔶 Warning 1
Call math rounding with 'int' argument 🔶 Warning 1
Mismatched query and update of 'StringBuilder' 🔶 Warning 1
Confusing primitive array argument to varargs method 🔶 Warning 1
Simplifiable conditional expression 🔶 Warning 1
String concatenation in loop 🔶 Warning 1
Suspicious variable/parameter name combination 🔶 Warning 1
'if' statement with identical branches ◽️ Notice 5
Constant values ◽️ Notice 3
'ThreadLocal.set()' with null as an argument ◽️ Notice 1
Vulnerable declared dependency ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QDJVM found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@ashesfall ashesfall merged commit 1c30bf7 into master Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant