Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add review links #213

Merged
merged 2 commits into from
Nov 6, 2019
Merged

feat: add review links #213

merged 2 commits into from
Nov 6, 2019

Conversation

MarceloAlves
Copy link
Contributor

@MarceloAlves MarceloAlves commented Oct 23, 2019 •
edited
Loading

What: Adding the linking of reviews made by the user

Why: Noticed that the link was just an anchor #review-marceloalves and since search params can be used on both GitHub/GitLab to filter PR's by reviewer, I thought I would add this

How: Followed how getLinkToIssues and getLinkToCommits were implemented. Added getLinkToReviews with URL template + tests

Checklist:

  • Documentation - Not quite sure documentation is needed. Looked but nothing stood out
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@MarceloAlves MarceloAlves changed the title feat: 🎸 add review links feat: add review links Oct 23, 2019
@Berkmann18 Berkmann18 requested a review from a team October 28, 2019 13:08
Berkmann18
Berkmann18 approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

@Berkmann18 Berkmann18 merged commit deee5d0 into all-contributors:master Nov 6, 2019
@Berkmann18
Copy link
Member

It seems you forgot to add yourself for tests as well.
@all-contributors Please add @MarceloAlves for test

@allcontributors
Copy link
Contributor

@Berkmann18

I could not determine your intention.

Basic usage: @all-contributors please add @jakebolam for code, doc and infra

For other usages see the documentation

@Berkmann18
Copy link
Member

@all-contributors Please add @MarceloAlves for test

@allcontributors allcontributors bot mentioned this pull request Nov 6, 2019
Merged
@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @MarceloAlves! 🎉

@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MarceloAlves MarceloAlves deleted the add-review-links branch November 6, 2019 22:25
Berkmann18 pushed a commit that referenced this pull request May 24, 2020
@JayDosunmu @jakebolam
docs: Fix some mispellings in run-bot-locally doc (#213)
045fbc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berkmann18 Berkmann18 Berkmann18 approved these changes

Assignees
No one assigned
Labels
enhancement released status: review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarceloAlves @Berkmann18 @all-contributors-release-bot