Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration tests #411

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

tenshiAMD
Copy link
Member

What:

  • Add configuration tests.

Why:

  • To make 100% test coverage.

How:

  • Add configuration tests.

Checklist:

  • Documentation
  • Ready to be merged
  • Added myself to contributors table.
    Bot Usage

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
app ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 3:28PM (UTC)

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 99.22% // Head: 100.00% // Increases project coverage by +0.77% 🎉

Coverage data is based on head (aebf797) compared to base (e6c6571).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head aebf797 differs from pull request most recent head 7999015. Consider uploading reports for the commit 7999015 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #411      +/-   ##
===========================================
+ Coverage   99.22%   100.00%   +0.77%     
===========================================
  Files          15        15              
  Lines         387       379       -8     
  Branches       47        41       -6     
===========================================
- Hits          384       379       -5     
+ Misses          3         0       -3     
Impacted Files Coverage Δ
lib/modules/config.js 100.00% <100.00%> (+4.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tenshiAMD tenshiAMD force-pushed the tenshiamd/add-configuration-tests branch from 546ad0d to f4815f4 Compare September 13, 2022 00:21
@tenshiAMD tenshiAMD force-pushed the tenshiamd/add-configuration-tests branch from f4815f4 to 5b15be5 Compare September 13, 2022 00:25
@tenshiAMD tenshiAMD changed the title chore: add configuration tests fix: add configuration tests Sep 13, 2022
@tenshiAMD tenshiAMD changed the title fix: add configuration tests feat: add configuration tests Sep 13, 2022
@tenshiAMD
Copy link
Member Author

@gr2m @Berkmann18 100% full tests coverage for the app. Cheers! 🎉

@tenshiAMD tenshiAMD self-assigned this Sep 13, 2022
@Berkmann18 Berkmann18 merged commit 89dbc86 into master Sep 13, 2022
@Berkmann18 Berkmann18 deleted the tenshiamd/add-configuration-tests branch September 13, 2022 17:33
@github-actions
Copy link

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

tenshiAMD added a commit that referenced this pull request Sep 19, 2022
chore: add configuration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants