Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary error handling #410

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

tenshiAMD
Copy link
Member

@tenshiAMD tenshiAMD commented Sep 11, 2022

What:

  • Found unnecessary error handling in app/lib/modules/repository.js

Why:

  • To achieve 100% test coverage.

How:

Checklist:

  • Documentation
  • Ready to be merged
  • Added myself to contributors table.
    Bot Usage

@tenshiAMD tenshiAMD requested a review from gr2m September 11, 2022 10:45
@tenshiAMD tenshiAMD self-assigned this Sep 11, 2022
@vercel
Copy link

vercel bot commented Sep 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
app ✅ Ready (Inspect) Visit Preview Sep 11, 2022 at 10:46AM (UTC)

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Base: 98.95% // Head: 99.21% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (e33b482) compared to base (8275d18).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   98.95%   99.21%   +0.25%     
==========================================
  Files          15       15              
  Lines         383      381       -2     
  Branches       46       46              
==========================================
- Hits          379      378       -1     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
lib/modules/repository.js 100.00% <100.00%> (+1.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gr2m gr2m merged commit 98a3a02 into master Sep 11, 2022
@gr2m gr2m deleted the tenshiamd/remove-unnecessary-error-handling branch September 11, 2022 21:17
@github-actions
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

tenshiAMD added a commit that referenced this pull request Sep 12, 2022
…ing-multiple-users-in-a-single-message

* origin/master: (103 commits)
  feat: commit conventions (#343)
  refactor: remove unnecessary error handling (#410)
  chore: fix codecov (#409)
  chore: remove all Slack references (#407)
  docs: add tenshiAMD as a contributor for code, maintenance, bug, review, test (#408)
  chore(deps): bump validator and smee-client (#406)
  fix(deps): bump `all-contributors-cli` (#404)
  fix(package): bump `all-contributors-cli` (#403)
  chore(deps): bump async from 3.2.1 to 3.2.3 (#396)
  chore(deps): bump eventsource from 1.1.0 to 1.1.1
  chore(deps): bump minimist from 1.2.5 to 1.2.6
  chore(deps): bump url-parse from 1.5.7 to 1.5.10
  chore(deps): bump node-fetch from 2.6.5 to 2.6.7
  chore(deps): bump url-parse from 1.5.3 to 1.5.7
  fix: bump max number of files to 25 (#385)
  docs: add aaltat as a contributor for bug (#383)
  fix: set `webhooksPath` correctly
  fix: Probot v12 (#381)
  chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9
  chore(deps): bump semver-regex from 3.1.2 to 3.1.3
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants