Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contribution-types): adds mentoring #314

Merged
merged 6 commits into from
Jan 18, 2021

Conversation

mloning
Copy link
Contributor

@mloning mloning commented Jul 23, 2020

What:
Add support for mentoring (see all-contributors/all-contributors#423)

Why:

How:
Added mentoring to src/tasks/processIssueComment/utils/parse-comment/index.js

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Comments:
If tests are needed, could you point me to the files that I have to change/add?

@mloning
Copy link
Contributor Author

mloning commented Aug 4, 2020

Seems like the test_and_deploy check got stuck? Is there anything else I need to do?

@mloning
Copy link
Contributor Author

mloning commented Aug 23, 2020

@all-contributors please add @mloning for code

@allcontributors
Copy link
Contributor

@mloning

I've put up a pull request to add @mloning! 🎉

@omarcostahamido
Copy link

bump

Hopefully this will get the `test_and_deploy` check to stop hanging
@Berkmann18
Copy link
Member

Hopefully, the required check will stop hanging.

@omarcostahamido
Copy link

omarcostahamido commented Oct 19, 2020

bump

(sorry for doing it again, but it has been a while...)

I'll do another PR if it's necessary (#321 ), just let me(us) know what we can do to get this merged.

Thanks!

@Berkmann18
Copy link
Member

@jakebolam Any ideas as to why this CI issue happens?

@vercel
Copy link

vercel bot commented Dec 30, 2020

@Berkmann18 is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

@omarcostahamido
Copy link

eeek
why is it so hard to fix this?

@omarcostahamido
Copy link

ok, now it is giving some more insightful information: conflicting files.

src/tasks/processIssueComment/utils/parse-comment/index.js
yarn.lock

@mloning can you fix the PR branch?
@Berkmann18 as soon as he does that, can you merge it?

thx

@mloning
Copy link
Contributor Author

mloning commented Jan 12, 2021

@omarcostahamido thanks for looking into this. Not sure what I have to do, git tells me the files I changed were deleted on master? Have they been moved?

@Berkmann18
Copy link
Member

The whole project had an overhaul, and the file where you changes would essentially move to is: https://github.com/all-contributors/app/blob/master/lib/parse-comment.js
@mloning So if you port your changes to that file (after rebasing), the PR should be mergeable. Apologies for the delay.

I was hoping to have documentation around the new architecture that will affect the other repos but life got on the way.

@mloning
Copy link
Contributor Author

mloning commented Jan 13, 2021

@omarcostahamido @Berkmann18 alright I cleaned it up - anything else still missing or is this good to go?

Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot!

@Berkmann18
Copy link
Member

@gr2m I see that Vercel is having an auth problem, is there anything we can do to fix that?
If not I'll merge it.

@vercel
Copy link

vercel bot commented Jan 14, 2021

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/all-contributors-app/settings/billing.

@gr2m
Copy link
Contributor

gr2m commented Jan 14, 2021

@gr2m I see that Vercel is having an auth problem, is there anything we can do to fix that?
If not I'll merge it.

I had to authorize the deploy because the PR is from a fork. I should be able to invite to the Vercel org, but it's $20/month, that I'm currently paying. Okay if I do the approvals for now, until we either get sponsoring from Vercel, or move to begin.com for deployments (which is something I'd like to do anyway)

@vercel
Copy link

vercel bot commented Jan 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/all-contributors-app/app/rohwwzvkr
✅ Preview: https://app-git-fork-mloning-mentoringemoji.all-contributors-app.vercel.app

@gr2m
Copy link
Contributor

gr2m commented Jan 14, 2021

You can install https://github.com/apps/all-contributors-preview for testing the change. Make sure you don't have https://github.com/apps/allcontributors installed on the same repository, the two might conflict with each other

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me:
gr2m/sandbox#163 (comment)

@Berkmann18 Berkmann18 merged commit 64fde8c into all-contributors:master Jan 18, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@omarcostahamido
Copy link

omg, we did it, at last!
thank you @mloning @Berkmann18 @gr2m
🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants