fix runtime body when api return void

aliyun · Jul 1, 2024 · f6764f6 · f6764f6
1 parent 2731549
commit f6764f6
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 5 deletions.
diff --git a/lib/semantic.js b/lib/semantic.js
@@ -1140,12 +1140,9 @@ class TypeChecker {
       env.inReturnsBlock = true;
       env.local.set('__response', _model('$Response'));
       this.visitReturnBody(ast.returns, env);
-      if (returnType.tag === Tag.TYPE && returnType.lexeme === 'void') {
-        // no check for void
-        return;
-      }
 
-      if (!this.hasReturnStmt(ast.returns.stmts)) {
+      if (!(returnType.tag === Tag.TYPE && returnType.lexeme === 'void') && 
+      !this.hasReturnStmt(ast.returns.stmts)) {
         this.error(`no return statement`, ast.apiName);
       }
     }

diff --git a/test/semantic.test.js b/test/semantic.test.js
@@ -6257,6 +6257,36 @@ describe('semantic', function () {
     }).to.not.throwException();
   });
 
+  it('runtime inferred type should be map when return type is void', function () {
+    const ast = parse(`
+    init() {}
+
+    api hello(): void {
+      __request.method = 'GET';
+      __request.pathname = '/';
+      __request.headers = {
+        host = 'www.test.com',
+      };
+      var retry = false;
+    } returns {
+      return;
+    } runtime {
+
+    }`, '__filename');
+    const runtimeBody = ast.moduleBody.nodes[1].runtimeBody;
+    expect(runtimeBody.inferred).to.eql({
+      'type': 'map',
+      'keyType': {
+        'type': 'basic',
+        'name': 'string'
+      },
+      'valueType': {
+        'type':'basic',
+        'name':'any'
+      }
+    });
+  });
+
   it('api runtime option can use request & response varibles', function(){
     expect(function () {
       parse(`