Support access token revocation, include nonce in ID token, other type fixes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, this PR includes some fixes that I had to apply in order to get my storage class implementation to pass type checking:
The
revoke_tokenendpoint needs to be updated to support the new parameters added in Implement token revocation endpoint aioauth#84, so that access tokens can be revoked in addition to refresh tokens.The nonce isn't being included in the ID token JWT claims.
Some various inconsequential type issues were present, like strings being used instead of the more specific ResponseType and TokenType classes, kwargs not being present, and the nonce parameter not being optional.
There are still some type errors that remain but I don't think they impact the behaviour.
Thanks for your cooperation with all the PRs this last week. As before this is not urgent for me so feel free to review it when you have time. Shawn