Add missing peer dependency from algoliasearch-helper #4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacinehmito
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 849aa8a:
|
The dependency algoliasearch-helper declares algoliasearch as a peer dependency [1], but instantsearch.js does not declare it as a dependency not a peer dependency. This can cause undefined issues during peer dependency resolution, and triggers warnings when using yarn v2+. The commit adds algoliasearch as a peer dependency. [1] https://github.com/algolia/algoliasearch-helper-js/blob/develop/package.json#L103
|
With typescript in mind it should probably indeed be a peer dependency, even though it's technically optional still |
|
I guess we could add it now. |
|
With npm v7 it breaks their build if they don't have it installed @tkrugg, so adding is a breaking change |
Haroenv
approved these changes
Dec 13, 2021
|
Thank you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency algoliasearch-helper declares algoliasearch as a peer dependency [1], but instantsearch.js does not declare it as a dependency nor a peer dependency.
This can cause undefined issues during peer dependency resolution, and triggers warnings when using yarn v2+.
The commit adds algoliasearch as a peer dependency.