Skip to content

Commit

Permalink
fix(deps): Add missing peer dependency (#4950)
Browse files Browse the repository at this point in the history
The dependency algoliasearch-helper declares algoliasearch as a peer
dependency [1], but instantsearch.js does not declare it as a dependency
not a peer dependency.
This can cause undefined issues during peer dependency resolution, and
triggers warnings when using yarn v2+.

The commit adds algoliasearch as a peer dependency.

[1] https://github.com/algolia/algoliasearch-helper-js/blob/develop/package.json#L103
  • Loading branch information
yacinehmito authored Dec 13, 2021
1 parent 1c56726 commit 468578d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,9 @@
"typescript": "4.3.5",
"webpack": "4.41.5"
},
"peerDependencies": {
"algoliasearch": ">= 3.1 < 5"
},
"resolutions": {
"places.js/algoliasearch": "3.35.0"
},
Expand Down

0 comments on commit 468578d

Please sign in to comment.