Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(themes): move to SCSS & sass-lint. #389

Merged
merged 1 commit into from
Oct 30, 2015

Conversation

redox
Copy link
Contributor

@redox redox commented Oct 29, 2015

Thanks to http://www.sasstoscss.com/ :)

Fix #384
Ref #290

@redox
Copy link
Contributor Author

redox commented Oct 29, 2015

@pixelastic 👍

@@ -54,9 +54,10 @@
"pretty-bytes": "^2.0.1",
"raw-loader": "^0.5.1",
"react-addons-test-utils": "^0.14.0",
"sass-lint": "^1.3.2",
"scsslint": "0.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need scsslint and sass-lint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, forgot to remove that one. On it. Good catch!

@redox
Copy link
Contributor Author

redox commented Oct 30, 2015

Done @pixelastic

pixelastic added a commit that referenced this pull request Oct 30, 2015
chore(themes): move to SCSS & sass-lint.
@pixelastic pixelastic merged commit 8f39f57 into develop Oct 30, 2015
@redox redox deleted the move-to-scss-and-sass-lint branch November 2, 2015 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants