Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stylelint with a Sass-aware linter #384

Closed
pixelastic opened this issue Oct 29, 2015 · 5 comments
Closed

Replace stylelint with a Sass-aware linter #384

pixelastic opened this issue Oct 29, 2015 · 5 comments
Assignees

Comments

@pixelastic
Copy link
Contributor

Our stylelint check is useless now that we are using Sass. We should use a linter aware of Sass syntax.

https://github.com/brigade/scss-lint should work.

Any other in mind?

@redox
Copy link
Contributor

redox commented Oct 29, 2015

LGTM 👍

@pixelastic
Copy link
Contributor Author

Actually scsslint only works with .scss syntax. We could use sasslint but I'll first wait to see if we stay on Sass or move to Scss (cf. #290)

@redox
Copy link
Contributor

redox commented Oct 29, 2015

https://github.com/brigade/scss-lint should work.

Actually, this is a ruby gem and the NPM package is actually only a JS binding that requires you to have it -> so I don't think it's a good move. What about https://github.com/sasstools/sass-lint (compliant with SCSS) ?

@pixelastic
Copy link
Contributor Author

@redox That's what I just said one message above :)

Edit: Oh, ok, same conclusion but not for the same reasons.

redox added a commit that referenced this issue Oct 30, 2015
@vvo
Copy link
Contributor

vvo commented Nov 2, 2015

was done and moving to waiting for release

@vvo vvo removed the in progress label Nov 2, 2015
@redox redox closed this as completed in f39a2a0 Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants