Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linting): ignore generated css #2445

Closed
wants to merge 8 commits into from
Closed

chore(linting): ignore generated css #2445

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d641474
chore(linting): ignore generated css
Haroenv Oct 4, 2017
a5bb89a
remove option to cli
Haroenv Oct 4, 2017
9ba9f84
Update .sass-lint.yml
Haroenv Oct 4, 2017
0cdb408
ignore vendors
Haroenv Oct 4, 2017
09e9caf
only warnings
Haroenv Oct 4, 2017
f81eced
Merge branch 'develop' into chore/sass-ignore
Haroenv Nov 1, 2017
5d7c7c3
Merge branch 'develop' into chore/sass-ignore
bobylito Nov 9, 2017
19f285a
Merge branch 'develop' into chore/sass-ignore
Haroenv Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .sass-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,10 @@ options:
formatter: stylish
files:
include:
'+(docs|src)/**/*.scss'
'+(docgen|src)/**/*.scss'
ignore:
- 'docs/_site/**'
- 'docs/_assets/stylesheets/bootstrap/**/*.scss' # Vendor
- 'docs/_assets/stylesheets/_syntax-highlighting.scss' # Vendor
- 'docs/examples/**/main.scss' # Files with front-matter
# Contains asset_path() call to jekyll-assets. sass-lint cannot disable rules inline
# https://github.com/sasstools/sass-lint/issues/70
- 'docs/_assets/stylesheets/_home.scss'
- 'docgen/src/stylesheets/vendors/**/*.scss'
- 'docgen/node_modules/**/*.scss'
rules:
# Extends
extends-before-mixins: 1
Expand Down Expand Up @@ -68,7 +63,7 @@ rules:
empty-args: 1
hex-length: 0
hex-notation:
- 2
- 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this value for? To reduce the criticality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it used to be an error, but a warning is better in this case, because we need to solve all the warnings, and I don't want to do it in this PR

-
style: uppercase
indentation: 1
Expand Down