chore(linting): ignore generated css #2445
Conversation
|
Yes but we should avoid to pass options to the CLI. There is a |
|
Deploy preview ready! Built with commit 19f285a https://deploy-preview-2445--algolia-instantsearch.netlify.com |
|
oops, didn't see that 😂 |
|
better like this @samouss ? |
|
Yes it's perfect! But there are a lot of errors in the We should fix it and ignore some of the vendor files (ex: bootstrap). |
| @@ -68,7 +63,7 @@ rules: | |||
| empty-args: 1 | |||
| hex-length: 0 | |||
| hex-notation: | |||
| - 2 | |||
| - 1 | |||
There was a problem hiding this comment.
What is this value for? To reduce the criticality?
There was a problem hiding this comment.
yes, it used to be an error, but a warning is better in this case, because we need to solve all the warnings, and I don't want to do it in this PR
|
What's the status on this @Haroenv? |
|
that it should be merged @bobylito |
|
@bobylito the CI is complaining about the commit format of the really old commits (initial commit etc.), did that always happen? |
Well I don't agree on lowering the criticality of lint checks because we don't have time to handle them. Don't we have a fix option to be able to fix this kind of problem automatically?
It should not I'll have a look. |
|
I guess the best would be to start again from a new branch forked from develop, cherry pick the changes and reopen the PR. |
ignore correct things now make hex rule a warning for now because we aren't consistent with it, we can fix it later when we want less warnings closes #2445
|
closing in favour of #2566 |
* chore(linting): target correct folder ignore correct things now make hex rule a warning for now because we aren't consistent with it, we can fix it later when we want less warnings closes #2445 * chore(sass-lint): update rules based on our usage * chore(scss): update files based on current rules There are still two kinds of lint errors that I'm not sure about. I'm not really in favor of forcing the nesting all the time. And not using qualifying elements can have unforeseen issues. * chore(theme): fix sass-lint errors * chore(style): enable empty-line-between-blocks
fixes #2443
There's a bunch of sass issues we should fix, or change the rules, feel free to contribute to this PR