Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instantsearch.widgets.searchBox does not apply custom cssClasses to search input #989

Closed
cmalpeli opened this issue Apr 25, 2016 · 2 comments

Comments

@cmalpeli
Copy link

Implementation:

search.addWidget(
    instantsearch.widgets.searchBox({
      container: '#search-box',
      placeholder: 'Search profiles...',
      wrapInput: true,
      cssClasses: {
         input: 'form-control search-input'
      }
    })
  );

Chrome (Mac) Output:
<input autocapitalize="off" autocomplete="off" autocorrect="off" placeholder="Search profiles..." role="textbox" spellcheck="false" type="text" value="" class="ais-search-box--input form-control search-input">

IE 11 Windows 10 PC Output:
<input class="ais-search-box--input" role="textbox" spellcheck="false" type="text" placeholder="Search profiles..." value="" autocapitalize="off" autocomplete="off" autocorrect="off">

You can see this in action on pythonjobs.com/profiles

Thanks!

@cmalpeli
Copy link
Author

Note the missing classes on the IE <input>

@vvo
Copy link
Contributor

vvo commented Apr 26, 2016

Thanks for reporting this, gonna have a quick look

@vvo vvo added the Type: Bug label Apr 26, 2016
@vvo vvo closed this as completed in ab10347 Apr 29, 2016
vvo pushed a commit that referenced this issue Apr 29, 2016
<a name="1.5.0"></a>
# [1.5.0](v1.4.5...v1.5.0) (2016-04-29)

### Bug Fixes

* **base href:** always create absolute URLS in widgets ([ae6dbf6](ae6dbf6)), closes [#970](#970)
* **IE11:** classList do not supports .add(class, class) ([ab10347](ab10347)), closes [#989](#989)
* **lifecycle:** save configuration done in widget.init ([07d1fea](07d1fea))
* **RefinementList:** use attributeNameKey when calling createURL ([253ec28](253ec28))
* **rootpath:** remember rootpath option on 'back' button ([01ecdaa](01ecdaa))
* **searchBox:** do not trigger a search when input value is the same ([81c2e80](81c2e80))
* **urlSync:** only start watching for changes at first render ([4a672ae](4a672ae))

### Features

* **urlSync:** allow overriding replaceState(state)/pushState(state) ([989856c](989856c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants