-
Notifications
You must be signed in to change notification settings - Fork 516
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(searchBox): do not trigger a search when input value is the same
This also avoids another IE11/10 bug where input event is triggered as soon as the user clicks in an input having a placeholder property.
- Loading branch information
vvo
committed
Apr 27, 2016
1 parent
4a672ae
commit 81c2e80
Showing
2 changed files
with
18 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81c2e80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I understand there is a bug in IE but can you tell us what are the other cases when this is triggered?
81c2e80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I did not write a complete message and I do not remember why, I tried to find why this would be needed.
Turns out any modifier key would trigger a new search if this code was not here, like using the CTRL key inside the field.
Instead of listing all the possible modifiers keys, maybe I did that, but unsure..
81c2e80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this triggering a bug to you?
81c2e80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I think you both replied to a comment I deleted before you replied but definitely enough time after I posted it that you got an email notification for it...
I think we can just drop this :)
81c2e80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont use email notifications ahah
81c2e80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer marking text like
blalbablalblablalbaUPDATE: nevermind, I was wrong.Instead of deleting comments, any comment is good, any deleted comment is lost forever :)
81c2e80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True :)
I just didn't want to bother you too much!