Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefinementListWidgetOptions.showMore should conditionally render #2160

Closed
timkelty opened this issue May 22, 2017 · 2 comments
Closed

RefinementListWidgetOptions.showMore should conditionally render #2160

timkelty opened this issue May 22, 2017 · 2 comments
Assignees
@bobylito
Labels
Design: API
Milestone
2.0

Comments

@timkelty
Copy link
Contributor

timkelty commented May 22, 2017 •
edited
Loading

Bug: What is the current behavior?
RefinementListWidgetOptions.showMore template always renders, regardless of # of facets or RefinementListWidgetOptions.limit.

It should only render when the requested # of facets is greater than RefinementListWidgetOptions.limit (v1 behavior), or some sort of disabled class should be applied so it can be hidden with CSS.

https://community.algolia.com/instantsearch.js/v2/widgets/refinementList.html#struct-RefinementListWidgetOptions-showMore

Looks like it was brought up here, but I'm not seeing it fixed in v2.0.0-beta.2: #1455.

This works as expected in v1. The show more block isn't rendered at all if it is not applicable.

What is the version you are using? Always use the latest one before opening a bug issue.
v2.0.0-beta.2
@bobylito
Copy link
Contributor

Thanks for the report @timkelty :)

Indeed we're missing an API in the connector that expresses the ability to actually do a toggle of the show more button. On it!

@bobylito bobylito self-assigned this May 22, 2017
bobylito pushed a commit that referenced this issue May 22, 2017
fix(show-more): should hide button when show more is not available
7947b22 
As noticed by @timkelty in #2160, showMore button should not be rendered
if there are not enough items to display based on the limits. With the
new connector API, this means that we should add a new parameter to
the renderer to give the information that this button should be
displayed.

fixes #2160
@bobylito bobylito mentioned this issue May 22, 2017
Merged
@bobylito
Copy link
Contributor

I created a new build with the fix for this issue 2.0.0-beta.3 http://cdn.jsdelivr.net/npm/instantsearch.js@2.0.0-beta.3/dist/instantsearch.min.js

@bobylito bobylito modified the milestone: 2.0 Jun 1, 2017
bobylito pushed a commit that referenced this issue Jul 1, 2017
v2.0.0
040ef90 
<a name="2.0.0"></a>
# [2.0.0](v1.11.15...v2.0.0) (2017-07-01)

### Bug Fixes

* **argos-ci:** blur the active element ([66d0551](66d0551))
* **connectNumericRefinementList:** reset page on refine ([22ec08d](22ec08d))
* **doc.build:** watch & rebuild `.pug` ([16d8542](16d8542))
* **doc.build/autoprefixer:** update mtime for onlyChanged plugin ([3b83e58](3b83e58))
* **escapeHits:** dont apply configuration if not requested ([c89f99d](c89f99d))

### Features

* **searchFunction:** make search function provide a better API ([8fc0831](8fc0831))

<a name="2.0.0-beta.5"></a>
# [2.0.0-beta.5](v1.11.12...v2.0.0-beta.5) (2017-06-01)

### Bug Fixes

* **Slider:** dont call `refine()` when it's disabled ([f1eabc9](f1eabc9))

### Features

* **hits:** opt-in xss filtering for hits and infinite hits. FIX #2138 ([4f67b48](4f67b48)), closes [#2138](#2138)

<a name="2.0.0-beta.4"></a>
# [2.0.0-beta.4](v1.11.11...v2.0.0-beta.4) (2017-05-24)

### Bug Fixes

* **misc:** IE 11 support ([072edfe](072edfe))
* **misc:** IE11 support without using transpiler ([324f062](324f062))
* **show-more:** should hide button when show more is not available (#2161) ([fbca3e6](fbca3e6)), closes [#2160](#2160)
* **Slider:** handle edge case where `min === max` ([22a5614](22a5614))
* **Slider:** restore `slider--handle-lower` && `slider--handle-upper` ([64d7ad2](64d7ad2))

<a name="2.0.0-beta.2"></a>
# [2.0.0-beta.2](v1.11.9...v2.0.0-beta.2) (2017-05-17)

### Bug Fixes

* **autoHideContainer:** dont prevent render with `shouldComponentUpdate` ([8c4b13f](8c4b13f))
* **clearsQuery:** not applied when only the query was not empty ([e7976ad](e7976ad))
* **connectors:** ensure `widgetParams` is at least an `{}` ([0c0e98f](0c0e98f))
* **connectRefinementList:** currentRefinements: return an array instead of first item ([a53223a](a53223a)), closes [#2102](#2102)
* **dev:docs:** dont watch `/docgen/rootFiles` ([ab1a7f5](ab1a7f5))
* **doc:** add doc for isFirstRendering ([cea6739](cea6739))
* **docs:** dont filter out `p.type.type` ([881659a](881659a))
* **documentation.js:** Support for record types ([219ecd9](219ecd9))
* **documentationjs:** add support litteral string types in type format ([2a08e7d](2a08e7d))
* **documentationjs:** deeper related types ([6e3121e](6e3121e))
* **documentationjs:** find related type in TypeApplication ([e0487ee](e0487ee))
* **documentationjs:** fix 2+ depth structs ([4c8b7ec](4c8b7ec))
* **documentationjs:** fixed default value parameter ([b62cbc7](b62cbc7))
* **documentationjs:** records display with , ([8a968f2](8a968f2))
* **documentationjs:** Updgrade to RC + fixes ([e9f0361](e9f0361))
* **infinite-hits:** Remove hitsPerPage option (#2128) ([c13e377](c13e377))
* **live-example:** adapt regex for matching connectors ([774254c](774254c))
* **pagination:** fix zealous find/replace ([e269d87](e269d87))
* **price-ranges:** fix test ([fd65cb3](fd65cb3))
* **price-ranges:** New API uses ranges ([a5a6916](a5a6916))
* **refinementList:** reimplement show more on refinement list ([72655ab](72655ab))
* **refinementList:** sffv fix thanks [@julienpa](https://github.com/julienpa) ([30e0e9a](30e0e9a))
* **sffv:** Fix exhaustive facets ([0cadcc3](0cadcc3))
* **sortby:** Consistent across widget / connectors + migration ([8e366cc](8e366cc))
* **widgets/price-ranges:** wrong compute of `templateProps` ([be5e063](be5e063))

### Features

* **connectHierarchicalMenu:** remove `currentRefinement` ([3912aaf](3912aaf))
* **connectHits:** typo `widgetOptions` -> `widgetParams` ([4420231](4420231))
* **connector:** Add hierarchical menu connector ([f727949](f727949))
* **connector:** add infinite hits connector ([cdf8675](cdf8675))
* **connector:** add instantsearchInstance to pagination render ([4fa96dc](4fa96dc))
* **connector:** add missing jsDoc descriptions ([e26e8e2](e26e8e2))
* **connector:** add range-slider ([1a02798](1a02798))
* **connector:** add tests for connectClearAll and connectHierarchicalMenu ([0eb29ec](0eb29ec))
* **connector:** Adds hits and menu connectors ([77083b7](77083b7))
* **connector:** Clear and CurrentRefinedValues ([02f7d3e](02f7d3e))
* **connector:** clearAll connector (iteration 2) ([90aa02e](90aa02e))
* **connector:** clearAll jsDoc + eslint fixes ([430a420](430a420))
* **connector:** complete jsdoc + pass instantsearch to view ([e125931](e125931))
* **connector:** connectClearAll documentation ([9b153aa](9b153aa))
* **connector:** connectClearAll iteration 2 (fix) ([03653f1](03653f1))
* **connector:** connectClearAll test ([5409157](5409157))
* **connector:** connectCurrentRefinedValues (iteration 2) ([68408de](68408de))
* **connector:** connectHierarchicalMenu (iteration 2) ([589454c](589454c))
* **connector:** connectHierarchicalMenu jsDoc ([e166090](e166090))
* **connector:** connectHits (iteration 2) ([bca09af](bca09af))
* **connector:** connectHitsPerPageSelector (iteration 2) ([26bb273](26bb273))
* **connector:** connectInfiniteHits (iteration 2) ([410459c](410459c))
* **connector:** connectNumericRefinementList (iteration 2) ([bfcf860](bfcf860))
* **connector:** connectNumericSelector (iteration 2) ([1eda8a2](1eda8a2))
* **connector:** connectNumericSelector jsDoc ([760fcea](760fcea))
* **connector:** connectRefinementList jsdoc + start document bool isFirstRendering ([52d13de](52d13de))
* **connector:** connectStats second iteration ([82b1cb3](82b1cb3))
* **connector:** connectToggle second iteration ([73b0878](73b0878))
* **connector:** fix createURL usage to generate correct urls ([fdf59d7](fdf59d7))
* **connector:** fix no param usage on custom infiniteHits ([961348a](961348a))
* **connector:** fix parameter consistency in connectClearAll ([9ddffd8](9ddffd8))
* **connector:** Fix parameters for toggle connector ([f96671c](f96671c))
* **connector:** hits-per-page-selector connector refactoring ([dd794e0](dd794e0))
* **connector:** jsDoc + check rendering function ([86f9739](86f9739))
* **connector:** jsDoc connectPagination ([3b284de](3b284de))
* **connector:** jsDoc for connectMenu ([626d5f1](626d5f1))
* **connector:** jsDoc updates ([c924043](c924043))
* **connector:** move clearAll as a rendering option ([ce41cde](ce41cde))
* **connector:** Numeric selector ([0dc42d2](0dc42d2))
* **connector:** numericRefinementList connector ([918d971](918d971))
* **connector:** pagination connector ([7a876f3](7a876f3))
* **connector:** price ranges connector ([d8bed96](d8bed96))
* **connector:** provide consistent interface for searchbox renderer ([17d8301](17d8301))
* **connector:** provide instantsearch instance at render ([12a7935](12a7935))
* **connector:** refactor search function ([618dca2](618dca2))
* **connector:** refinement list connector ([c8fcf4e](c8fcf4e))
* **connector:** remove legacy implementation of toggle ([04437b0](04437b0))
* **connector:** remove non relevant instantsearch API from test ([c5dce5c](c5dce5c))
* **connector:** remove unused parameter to searchbox connector ([e639f65](e639f65))
* **connector:** searchbox connector ([70f8e1f](70f8e1f))
* **connector:** small internal refactoring for SFFV ([cb5c1fa](cb5c1fa))
* **connector:** sort by selector connector ([b9847cf](b9847cf))
* **connector:** star rating connector ([9996b4d](9996b4d))
* **connector:** stats connector ([680743b](680743b))
* **connector:** test connectHits ([89c86a5](89c86a5))
* **connector:** test connectHitsPerPageSelector ([9caab02](9caab02))
* **connector:** test connectInfiniteHits ([e67e75e](e67e75e))
* **connector:** test connectMenu ([03c6f11](03c6f11))
* **connector:** test connectNumericRefinementList ([2f26251](2f26251))
* **connector:** test connectNumericSelector ([182779b](182779b))
* **connector:** test connectPagination ([6f125b7](6f125b7))
* **connector:** test connectPriceRanges ([f5dfba7](f5dfba7))
* **connector:** test connectRangeSlider ([4f6c180](4f6c180))
* **connector:** test connectSearchBox ([b4d7e1b](b4d7e1b))
* **connector:** test connectSortBySelector ([e8825df](e8825df))
* **connector:** test connectStarRating ([0c16f15](0c16f15)), closes [#2002](#2002)
* **connector:** test connectStats ([c992288](c992288))
* **connector:** test connectToggle ([441293d](441293d))
* **connector:** toggle connector ([bf9a9c0](bf9a9c0))
* **connector:** update doc, move setValue to refine in SortBySelector ([2486f36](2486f36))
* **connector:** update jsDoc descriptions ([f83022a](f83022a))
* **connectors:** `refinement-list` widget (iteration2) ([1c6c3a5](1c6c3a5))
* **connectors:** `setValue()` -> `refine()` / `currentValue` -> `currentRefinement` ([ec7806c](ec7806c))
* **connectors:** `sortBy` to `['isRefined', 'count:desc']` ([01219f1](01219f1))
* **connectors:** add `currentRefinement` on `hierarchical-menu` ([154cdb5](154cdb5))
* **connectors:** connectPagination (iteration2) ([8a615f6](8a615f6))
* **connectors:** connectPriceRanges (iteration2) ([e34968e](e34968e))
* **connectors:** connectRangeSlider (iteration2) ([6073d94](6073d94))
* **connectors:** connectSearchBox (iteration2) ([3161c9b](3161c9b))
* **connectors:** connectSortBySelector (iteration 2) ([dec2d31](dec2d31))
* **connectors:** connectStarRating (iteration2) ([7ef7b6b](7ef7b6b))
* **connectors:** connectToggle, forward initial options to render ([704a455](704a455))
* **connectors:** dissociate logic & view for `menu` widget ([5a02c88](5a02c88))
* **connectors:** expose connectors on `instantsearch` instance ([ff799d0](ff799d0))
* **connectors:** forward `widgetParams` to `renderFn` ([54222a3](54222a3))
* **connectors:** jsDoc connectHitsPerPageSelector ([75243b0](75243b0))
* **connectors:** provide `currentRefinement` on menu ([fb7bc5e](fb7bc5e))
* **connectors:** provide `currentRefinement` on numeric refinement list ([91f7928](91f7928))
* **connectors.numeric-selector:** `currentValue` -> `currentRefinement` / `setValue()` -> `refine()` ([998faf1](998faf1))
* **connectors.price-ranges:** provides `currentRefiment` value ([39af437](39af437))
* **connectors.refinement-list:** provide `currentRefinement` to `renderFn` ([7e86be3](7e86be3))
* **connectors.star-rating:** provide `currentRefinement` value ([c08b3e4](c08b3e4))
* **connectRefinementList:** first good iteration ([88fd6d5](88fd6d5))
* **doc:** re-bootstrap doc based on instantsearch-android ([e4e816e](e4e816e))
* **docs:** bootstrap v2 docs ([0db6caf](0db6caf))
* **docs:** pages structure ([fe89dcf](fe89dcf))
* **getting-started:** add `.zip` boilerplate ([7d3769c](7d3769c))
* **getting-started:** add result example of guide ([78d9017](78d9017))
* **live-example:** add support of connectors ([e4f3158](e4f3158))
* **live-example:** include jquery on connectors example pages ([f32936f](f32936f))
* **main:** export all the widgets at once ([4bc2d21](4bc2d21))
* **numeric-refinement-list:** `facetValues` -> `items` / `toggleRefinement` -> `refine` ([eb2c993](eb2c993))
* **pagination:** `setPage()` -> `refine()` / `currentPage` -> `currentRefinement` ([f783fea](f783fea))
* **range-slider:** use `rheostat` as slider component (#2142) ([910a0a0](910a0a0))
* **searchFunction:** Update API, fix #1924 ([c7beb1d](c7beb1d)), closes [#1924](#1924)
* **sort-by-selector:** `currentValue` -> `currentRefinement` ([e94c8c7](e94c8c7))
* **Template:** remove support for react element ([ca2ab44](ca2ab44))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobylito bobylito

Labels
Design: API
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@timkelty @bobylito @Haroenv