fix(escapeHits): dont apply configuration if not requested

algolia · Jun 7, 2017 · c89f99d · c89f99d
1 parent 9ed3353
commit c89f99d
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 6 deletions.
diff --git a/src/connectors/hits/__tests__/connectHits-test.js b/src/connectors/hits/__tests__/connectHits-test.js
@@ -13,7 +13,7 @@ describe('connectHits', () => {
     // flag set accordingly
     const rendering = sinon.stub();
     const makeWidget = connectHits(rendering);
-    const widget = makeWidget();
+    const widget = makeWidget({escapeHits: true});
 
     expect(widget.getConfiguration()).toEqual({
       highlightPreTag: '__ais-highlight__',
@@ -37,7 +37,7 @@ describe('connectHits', () => {
     expect(rendering.callCount).toBe(1);
     // test if isFirstRendering is true during init
     expect(rendering.lastCall.args[1]).toBe(true);
-    expect(rendering.lastCall.args[0].widgetParams).toEqual({});
+    expect(rendering.lastCall.args[0].widgetParams).toEqual({escapeHits: true});
 
     widget.render({
       results: new SearchResults(helper.state, [{}]),
@@ -49,7 +49,7 @@ describe('connectHits', () => {
     // test that rendering has been called during init with isFirstRendering = false
     expect(rendering.callCount).toBe(2);
     expect(rendering.lastCall.args[1]).toBe(false);
-    expect(rendering.lastCall.args[0].widgetParams).toEqual({});
+    expect(rendering.lastCall.args[0].widgetParams).toEqual({escapeHits: true});
   });
 
   it('Provides the hits and the whole results', () => {

diff --git a/src/connectors/hits/connectHits.js b/src/connectors/hits/connectHits.js
@@ -60,7 +60,9 @@ export default function connectHits(renderFn) {
 
   return (widgetParams = {}) => ({
     getConfiguration() {
-      return tagConfig;
+      return widgetParams.escapeHits
+        ? tagConfig
+        : undefined;
     },
 
     init({instantSearchInstance}) {

diff --git a/src/connectors/infinite-hits/__tests__/connectInfiniteHits-test.js b/src/connectors/infinite-hits/__tests__/connectInfiniteHits-test.js
@@ -14,6 +14,7 @@ describe('connectInfiniteHits', () => {
     const rendering = sinon.stub();
     const makeWidget = connectInfiniteHits(rendering);
     const widget = makeWidget({
+      escapeHits: true,
       hitsPerPage: 10,
     });
 
@@ -40,6 +41,7 @@ describe('connectInfiniteHits', () => {
     // test if isFirstRendering is true during init
     expect(rendering.lastCall.args[1]).toBe(true);
     expect(rendering.lastCall.args[0].widgetParams).toEqual({
+      escapeHits: true,
       hitsPerPage: 10,
     });
 
@@ -56,6 +58,7 @@ describe('connectInfiniteHits', () => {
     expect(rendering.callCount).toBe(2);
     expect(rendering.lastCall.args[1]).toBe(false);
     expect(rendering.lastCall.args[0].widgetParams).toEqual({
+      escapeHits: true,
       hitsPerPage: 10,
     });
   });

diff --git a/src/connectors/infinite-hits/connectInfiniteHits.js b/src/connectors/infinite-hits/connectInfiniteHits.js
@@ -82,7 +82,9 @@ export default function connectInfiniteHits(renderFn) {
 
     return {
       getConfiguration() {
-        return tagConfig;
+        return widgetParams.escapeHits
+          ? tagConfig
+          : undefined;
       },
 
       init({instantSearchInstance, helper}) {

diff --git a/src/widgets/infinite-hits/__tests__/infinite-hits-test.js b/src/widgets/infinite-hits/__tests__/infinite-hits-test.js
@@ -37,7 +37,7 @@ describe('infiniteHits()', () => {
       templates: defaultTemplates,
       useCustomCompileOptions: {item: false, empty: false},
     };
-    widget = infiniteHits({container, cssClasses: {root: ['root', 'cx']}});
+    widget = infiniteHits({container, escapeHits: true, cssClasses: {root: ['root', 'cx']}});
     widget.init({helper, instantSearchInstance: {}});
     results = {hits: [{first: 'hit', second: 'hit'}]};
   });