-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directory-
and script-
adapters
#6
Conversation
Oh, yeah - this PR is currently missing tests. I am more than happy to contribute tests, but I'll wait to see whether you approve of the changes in this form, first. Also, one thought I had while authoring this - it might be a good idea to pass the |
Hi @Lordfirespeed awesome, thanks for the contributions and new ideas. I will try to check your changes later (probably later today or during the weekend) 👍! But for sure tests are needed (after checking your code i could also collaborate on that if you need support), I want to make sure we keep the lib with good coverage and quality :). |
src/lib/adapters/directory-adapter/resolution-and-load-order.ts
Outdated
Show resolved
Hide resolved
…gFiles dotindex case
Seems we ended up both doing a similar thing 😂 - feel free to mess around/rearrange/remove what I've added |
thanks! If no further requirements / changes from your side, I can approve the PR 👍 |
Everything LGTM! ❤️ |
config
) #4Motivation / usage example: Lordfirespeed/test-zod-config-directory