Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory- and script- adapters #6

Merged
merged 17 commits into from
Jul 3, 2024
Merged

Conversation

Lordfirespeed
Copy link
Contributor

@Lordfirespeed Lordfirespeed commented Jun 28, 2024

@Lordfirespeed
Copy link
Contributor Author

Lordfirespeed commented Jun 28, 2024

Oh, yeah - this PR is currently missing tests. I am more than happy to contribute tests, but I'll wait to see whether you approve of the changes in this form, first.

Also, one thought I had while authoring this - it might be a good idea to pass the logger into adapter.read()? that would allow the directory adapter to log failures per-file rather than per- top-level adapter.

@alexmarqs
Copy link
Owner

Hi @Lordfirespeed awesome, thanks for the contributions and new ideas. I will try to check your changes later (probably later today or during the weekend) 👍! But for sure tests are needed (after checking your code i could also collaborate on that if you need support), I want to make sure we keep the lib with good coverage and quality :).

@Lordfirespeed
Copy link
Contributor Author

Seems we ended up both doing a similar thing 😂 - feel free to mess around/rearrange/remove what I've added

@alexmarqs
Copy link
Owner

thanks! If no further requirements / changes from your side, I can approve the PR 👍

@Lordfirespeed
Copy link
Contributor Author

Lordfirespeed commented Jul 2, 2024

thanks! If no further requirements / changes from your side, I can approve the PR 👍

Everything LGTM! ❤️

@alexmarqs alexmarqs merged commit 128a769 into alexmarqs:main Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript / TypeScript file adapter Hierarchical configuration (a la config)
2 participants