Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Provide full JSON key path in labelRenderer (in reverse order) #32

Merged
merged 1 commit into from
Feb 23, 2016
Merged

Provide full JSON key path in labelRenderer (in reverse order) #32

merged 1 commit into from
Feb 23, 2016

Conversation

alexkuz
Copy link
Owner

@alexkuz alexkuz commented Feb 22, 2016

Before:

labelRenderer(key) => <span>{key}</span>

After:

labelRenderer(key, parentKey, ..., rootKey) => <span>{key}</span>

This can be used to determine exact position in data object (to navigate in onClick handler, for example).

@gaearon
Copy link
Collaborator

gaearon commented Feb 23, 2016

I would love to see this merged. It enables a great use case in https://github.com/alexkuz/redux-devtools-inspector.

chibicode added a commit that referenced this pull request Feb 23, 2016
Provide full JSON key path in labelRenderer (in reverse order)
@chibicode chibicode merged commit 0370e2d into alexkuz:master Feb 23, 2016
@chibicode
Copy link
Contributor

@alexkuz @gaearon merged in 0.5.6!

@alexkuz
Copy link
Owner Author

alexkuz commented Feb 23, 2016

👏

@leonaves
Copy link

@alexkuz This whole workflow breaks immutable support in redux-devtools-inspector. I'm hoping to submit a pull request soon, but you know your code better than I do so if you come up with a way to easily fix that it might be simpler than whatever I might come up with?

@leonaves
Copy link

Okay so I might have been a bit eager with why immutable does not work in Inspector. One issue is actually with react-json-tree which I've reported here: #34 and the other is that your JSONDiff module doesn't support Iterables at all. I imagine this is probably something you've already realised in the latter case, but if you haven't even considered making progress on this I'd be happy to help out, as I love the look of this monitor and really would like to start integrating it into my workflow. For now I'm running a forked version with 'state' as the default tab and hideRoot set to false, but I'd love to take advantage of some of the more advanced features, and if contributing would help speed that up let me know.

@alexkuz
Copy link
Owner Author

alexkuz commented Feb 26, 2016

@leonaves can you file an issue to redux-devtools-monitor? I haven't check Immutables yet as I'm not really using them (though I should).

@leonaves
Copy link

Do you mean redux-devtools-inspector?

@alexkuz
Copy link
Owner Author

alexkuz commented Feb 26, 2016

@leonaves yeah, sorry :)

@gaearon
Copy link
Collaborator

gaearon commented Mar 1, 2016

Looks like this broke https://github.com/gaearon/redux-devtools-log-monitor:

gaearon/redux-devtools-log-monitor#39

This is a public API change and should have been a minor bump rather than a patch bump.

@gaearon
Copy link
Collaborator

gaearon commented Mar 1, 2016

For now I locked redux-devtools-log-monitor to use 0.5.5. The solution here would be:

  1. Release 0.5.7 that undoes the change in 0.5.6
  2. Release 0.6.0 that introduces it again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants