-
Notifications
You must be signed in to change notification settings - Fork 115
Provide full JSON key path in labelRenderer (in reverse order) #32
Conversation
I would love to see this merged. It enables a great use case in https://github.com/alexkuz/redux-devtools-inspector. |
Provide full JSON key path in labelRenderer (in reverse order)
👏 |
@alexkuz This whole workflow breaks immutable support in redux-devtools-inspector. I'm hoping to submit a pull request soon, but you know your code better than I do so if you come up with a way to easily fix that it might be simpler than whatever I might come up with? |
Okay so I might have been a bit eager with why immutable does not work in Inspector. One issue is actually with react-json-tree which I've reported here: #34 and the other is that your JSONDiff module doesn't support Iterables at all. I imagine this is probably something you've already realised in the latter case, but if you haven't even considered making progress on this I'd be happy to help out, as I love the look of this monitor and really would like to start integrating it into my workflow. For now I'm running a forked version with 'state' as the default tab and hideRoot set to false, but I'd love to take advantage of some of the more advanced features, and if contributing would help speed that up let me know. |
@leonaves can you file an issue to |
Do you mean redux-devtools-inspector? |
@leonaves yeah, sorry :) |
Looks like this broke https://github.com/gaearon/redux-devtools-log-monitor: gaearon/redux-devtools-log-monitor#39 This is a public API change and should have been a minor bump rather than a patch bump. |
For now I locked
|
Before:
After:
This can be used to determine exact position in data object (to navigate in
onClick
handler, for example).