-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix incorrectly formatted json data #812
Merged
alexjustesen
merged 45 commits into
v0.16.0-dev
from
fix-incorrectly-formatted-json-data
Feb 19, 2024
Merged
[Bug] Fix incorrectly formatted json data #812
alexjustesen
merged 45 commits into
v0.16.0-dev
from
fix-incorrectly-formatted-json-data
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjustesen
modified the milestones:
v0.x.0 (Import / export / backup and DQ),
v0.15.0 (Data quality)
Dec 13, 2023
alexjustesen
changed the title
[Bugfix] Fix incorrectly formatted json data
[Bug] Fix incorrectly formatted json data
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Description
This PR fixes incorrectly formatted json data in a Result's
data
column.FAQ
results_bad_json
for safe keeping.results
tableresults_bad_json
will remain in the database unless you decide to manually drop the table.Process
Database Migration (automated)
The following steps will occur automatically as part of the
0.16.0
version.results
toresults_bak_bad_json
so theirs a copy of existing data.results
table with an updated DDL.admin
user that manual action is required.Data Migration (manual)
The following steps will be required should users want to move their data over once they've upgraded to
v0.16.0
. NOTE: this only applies to existing installs with existing results data.results_bad_json
toresults
with the new DDL format.To-dos
🪵 Changelog
➕ Added
MigrateBadJsonResults
action to move result data fromresults_bad_json
toresults
.Result
model attributes to get additional information fromdata
column.download_jitter
ip_address
isp
packet_loss
ping_jitter
result_url
server_host
server_id
server_name
upload_jitter
service
which preps for supporting multiple speedtest services (other than Ookla).ResultStatus
enum to strictly set the result's status.ip_address
result table filterstatus
result table filterupdated_at
back to theResult
model.✏️ Changed
Completed
speedtests.Results
table to show additional columns and supportNumber
helper.formatForInfluxDB2()
method to use model attributes.🔧 Fixed
data
column in theresults
table.🗑️ Removed
$fillable = []
Result model attribute in favor of$guarded = []
getJitterData()
method from Result model, no longer needed.