fix: skip abstract classes when registering via AddWorksFromAssembly

alexalok · Mar 2, 2023 · 325fac0 · 325fac0
1 parent 8e9e33a
commit 325fac0
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/dotWork.Tests/WorkStubs/Work_Abstract.cs b/dotWork.Tests/WorkStubs/Work_Abstract.cs
@@ -0,0 +1,9 @@
+using System.Threading.Tasks;
+
+namespace dotWork.Tests.WorkStubs
+{
+    public abstract class Work_Abstract<TWorkOptions> : WorkBase<TWorkOptions> 
+        where TWorkOptions: class, IWorkOptions
+    {
+    }
+}
diff --git a/dotWork.lutconfig b/dotWork.lutconfig
@@ -0,0 +1,6 @@
+<LUTConfig Version="1.0">
+  <Repository />
+  <ParallelBuilds>true</ParallelBuilds>
+  <ParallelTestRuns>true</ParallelTestRuns>
+  <TestCaseTimeout>180000</TestCaseTimeout>
+</LUTConfig>
diff --git a/dotWork/Extensions/ContainerExtensions.cs b/dotWork/Extensions/ContainerExtensions.cs
@@ -121,7 +121,10 @@ public static IServiceCollection AddWorksFromAssembly(
             if (configuration is null)
                 throw new ArgumentNullException(nameof(configuration));
 
-            var workTypes = assembly.GetTypes().Where(t => t.ImplementsInterface(typeof(IWork<>)));
+            var workTypes = assembly.GetTypes().Where(t => 
+                t.ImplementsInterface(typeof(IWork<>))
+                && !t.IsAbstract
+                );
             foreach (var workType in workTypes)
             {
                 if (typeSelector?.Invoke(workType) == false)

diff --git a/dotWork/dotWork.csproj b/dotWork/dotWork.csproj
@@ -7,10 +7,10 @@
 	<PropertyGroup>
 		<Authors>alexalok</Authors>
 		<Description>.NET Workers made easy</Description>
-		<Copyright>Copyright © alexalok 2021</Copyright>
-		<Version>1.5.0</Version>
+		<Copyright>Copyright © alexalok 2021-2023</Copyright>
+		<Version>1.5.1</Version>
 		<PackageReleaseNotes>
-			* Introduced WorkHost.OnWorkStopped and IWork.OnIterationException events.
+			* fix: skip abstract classes when registering via AddWorksFromAssembly
 		</PackageReleaseNotes>
 		<PackageProjectUrl></PackageProjectUrl>
 		<RepositoryUrl>https://github.com/alexalok/dotWork</RepositoryUrl>