Update state without checking values #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we discussed setting default state to in game, and keeping level != Null + lines == 000 or 25 and score == 000000 to start game? Could you do that (or I can too...) |
|
Oh I forgot about this PR 😅 Let me update it to what we discussed. |
timotheeg
force-pushed
the
simpler_state_transition
branch
3 times, most recently
from
1bab416
to
0b1100a
Compare
|
Done |
timotheeg
force-pushed
the
simpler_state_transition
branch
from
0b1100a
to
6a755a3
Compare
|
@alex-ong this is ready to merge I think 😃 Pls check |
|
I didnt check, i'm going to blind merge 🍷 |
|
Lol, I completely forgot this PR! I hope it doesn't introduce a bug 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting capture mid-game,
gameidstays at 0, and game state incorrectly stays atMENU.Opening a small changeset for discussion.