Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task queue for Aleph and ingest-file backed by RabbitMQ #63

Merged
merged 21 commits into from
Jul 13, 2022

Conversation

sunu
Copy link
Contributor

@sunu sunu commented Mar 29, 2022

Part of fixing alephdata/aleph#2127

  • Implements a worker that listens on one or more RabbitMQ queues.
  • Queue state per collection is stored in Redis and it tracks finished task count as an integer and pending tasks and running tasks as a set
  • Late acknowledgement is enabled in RabbitMQ. So tasks are retried if a worker disconnects without sending an acknowledgement

@sunu sunu marked this pull request as ready for review May 2, 2022 07:39
@sunu sunu changed the title WIP task queue for Aleph and ingest-file backed by RabbitMQ Task queue for Aleph and ingest-file backed by RabbitMQ May 2, 2022
@sunu
Copy link
Contributor Author

sunu commented Jul 13, 2022

@Rosencrantz I want to merge this and make a minor release. Since we have added the new worker implementation in a different module, merging this branch won't break anything that use the old worker implementation. What do you think?

@Rosencrantz
Copy link
Contributor

@Rosencrantz I want to merge this and make a minor release. Since we have added the new worker implementation in a different module, merging this branch won't break anything that use the old worker implementation. What do you think?

To be clear, you're looking to do some sort of beta or RC type release as discussed right?

@Rosencrantz
Copy link
Contributor

This looks fine, the work here (in the most part) seems additive rather than changing existing code so I'm not too concerned about it having a detrimental impact. Also this is to be used as a 'beta' for further testing.

@Rosencrantz Rosencrantz merged commit 65eb0c3 into master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants