Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mixing parameters #1859

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Updated mixing parameters #1859

merged 1 commit into from
Jul 29, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jul 29, 2024

Fixes #1603

Summary by Sourcery

This pull request enhances the TextImage and OverlayElements classes by adding new functionality to handle additional parameters in the apply_with_params method. It also updates the documentation with reference links for further context.

  • Enhancements:
    • Added a new method apply_with_params to the TextImage class to handle overlay data transformation.
    • Enhanced the apply_with_params method in the OverlayElements class to include mix_data in the result.
  • Documentation:
    • Added a reference link to the TextImage and OverlayElements class docstrings for additional context.

Copy link
Contributor

sourcery-ai bot commented Jul 29, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #1603 by adding reference links to the doc-augmentation repository in the TextImage and OverlayElements classes. Additionally, it introduces a new method apply_with_params in TextImage to handle additional parameters for text overlays and updates the apply_with_params method in OverlayElements to include mix_data in the result.

File-Level Changes

Files Changes
albumentations/augmentations/text/transforms.py
albumentations/augmentations/mixing/transforms.py
Added reference links to the doc-augmentation repository and updated apply_with_params methods to handle additional parameters.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider optimizing the new apply_with_params method in the TextImage class to avoid potential data duplication. Could this information be returned more efficiently?
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ternaus ternaus merged commit 33c8927 into main Jul 29, 2024
17 checks passed
@ternaus ternaus deleted the update_mixing_returns branch July 29, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Return Mixing Data from MixUp
1 participant