-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove get_params_dependent_on_targets
#1857
Remove get_params_dependent_on_targets
#1857
Conversation
targets_as_params
Reviewer's Guide by SourceryThis pull request refactors the method File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ayasyrev - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
please rerun actions. |
Change
get_params_dependent_on_targets
toget_params_dependent_on_data
Now only
Equalize
uses it.Summary by Sourcery
This pull request refactors the method
get_params_dependent_on_targets
toget_params_dependent_on_data
across various augmentation and transformation classes. It also updates the parameter handling to useparams['shape']
instead ofparams['image']
for improved generalization.get_params_dependent_on_targets
toget_params_dependent_on_data
across multiple files for consistency and clarity.params['image']
withparams['shape']
to generalize parameter handling and improve flexibility.