-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shape to params #1846
Add shape to params #1846
Conversation
Reviewer's Guide by SourceryThis pull request adds the 'shape' parameter to various transformation functions and test cases. The changes ensure that shape dimensions are passed correctly to transformation methods, improving the accuracy of geometric transformations. Additionally, some test cases were reformatted for better readability. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ayasyrev - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 14 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 4 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Add "shape" to params
Summary by Sourcery
This pull request enhances geometric transformation functions by adding image shape parameters to ensure more accurate transformations. Corresponding test cases have been updated to validate these changes.