Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shape to params #1846

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

ayasyrev
Copy link
Contributor

@ayasyrev ayasyrev commented Jul 17, 2024

Add "shape" to params

Summary by Sourcery

This pull request enhances geometric transformation functions by adding image shape parameters to ensure more accurate transformations. Corresponding test cases have been updated to validate these changes.

  • Enhancements:
    • Updated geometric transformation functions to include image shape parameters for more accurate transformations.
  • Tests:
    • Modified test cases to include shape parameters in function calls for validation of geometric transformations.

Copy link
Contributor

sourcery-ai bot commented Jul 17, 2024

Reviewer's Guide by Sourcery

This pull request adds the 'shape' parameter to various transformation functions and test cases. The changes ensure that shape dimensions are passed correctly to transformation methods, improving the accuracy of geometric transformations. Additionally, some test cases were reformatted for better readability.

File-Level Changes

Files Changes
albumentations/augmentations/geometric/transforms.py
albumentations/augmentations/geometric/rotate.py
Updated transformation methods to pass shape dimensions from params.
tests/test_transforms.py
tests/test_core.py
tests/test_serialization.py
Updated test cases to include shape dimensions in function calls.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ayasyrev - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 14 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 4 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

albumentations/augmentations/geometric/transforms.py Outdated Show resolved Hide resolved
albumentations/core/transforms_interface.py Show resolved Hide resolved
tests/test_transforms.py Show resolved Hide resolved
tests/test_transforms.py Show resolved Hide resolved
tests/test_serialization.py Show resolved Hide resolved
tests/test_serialization.py Show resolved Hide resolved
@ternaus ternaus merged commit c87c214 into albumentations-team:main Jul 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants