Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tools #60

Merged
merged 8 commits into from
May 1, 2024
Merged

Improve tools #60

merged 8 commits into from
May 1, 2024

Conversation

albertziegenhagel
Copy link
Owner

@albertziegenhagel albertziegenhagel commented May 1, 2024

Some minor improvements & clean-up for the utility tools.

This is mainly about naming the tools "tools" instead of "apps" and improving the detection and error reporting of invalid/unsupported ETL files.

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 83.01%. Comparing base (6d03ff8) to head (b1cc22f).

Files Patch % Lines
snail/etl/etl_file.cpp 34.78% 7 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   83.31%   83.01%   -0.31%     
==========================================
  Files         102      102              
  Lines        4310     4322      +12     
  Branches      829      837       +8     
==========================================
- Hits         3591     3588       -3     
- Misses        339      346       +7     
- Partials      380      388       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertziegenhagel albertziegenhagel marked this pull request as ready for review May 1, 2024 17:43
They are not currently supported
Mainly to fix some warnings emitted by clang.
@albertziegenhagel albertziegenhagel merged commit d1e4a7b into main May 1, 2024
6 of 8 checks passed
@albertziegenhagel albertziegenhagel deleted the tools branch May 1, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant