Update backend #263
Merged
Update backend #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and clean up imports. Types are grouped in `/utils/types.py` for convenience.
Checked "dead-ness" using vulture, code search and pytest. From layers.py: * Constant * Zero * One * ZerosLike * Greater * Less * LessThanZero * GreaterEqual * LessEqual * GreaterEqualThanZero * Print From graph.py: * get_layer_outbound_count From checks.py: * get_current_layers * get_known_layers * is_relu_convnet_layer
and an import in the middle of the file.
reduces type complexity and fixes possible bug with `iK.gradients`.
Adds: * type hints * assert that `clip_all_reversed_tensors` really is either False or tuple of min/max values. * remove the dynamic attribute removing and checking from `reversed_tensors`, enabling us to... * turn `reversed_tensors` into a fixed TypedDict, allowing type checking
adrhill
commented
Jul 8, 2021
first or-statement would return true if layer contains any activation.
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 71.36% 72.55% +1.19%
==========================================
Files 41 43 +2
Lines 4173 4129 -44
Branches 637 614 -23
==========================================
+ Hits 2978 2996 +18
+ Misses 1007 948 -59
+ Partials 188 185 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the backend in preparation for the switch to TF2.0.
I tried to not touch
innvestigate/analyzersto keep this commit a bit more concise. Further type annotations and fixes will follow as soon as this is merged.Changes
Type annotations
Adds type annotations to the backend, making refactoring a whole lot easier going forward. Static type checking can be run by calling
In the future, this should be included as part of CI.
Bug fixes
contains_activationand added testsDeepTaylorto match changesreverse_modelis_layer_at_idx. (I'll open an issue on this topic.)Dead code removal
Linting fixes
Updated lots of small things to appease pylint and flake8, mostly updating variable names with more meaningful ones and untangling if-else-statements.