-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/webapi-mapfeatures #826
Merged
albar965
merged 43 commits into
albar965:master
from
KOKAProduktion:feature/webapi-mapfeatures
Mar 8, 2022
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
1c1b928
Add new MapActionsController and imageAction
KOKAProduktion 32f1f3c
Clone WebMapController logic to MapActionsController
KOKAProduktion 50d0c6f
Merge branch 'feature/webapi' into feature/webapi-marble-tiled-output
KOKAProduktion 332e848
Add missing image retrieval params
KOKAProduktion 5539560
Remove copyright note from marble output
KOKAProduktion c6fbabe
Disable dynamic/live features
KOKAProduktion 9ab4234
Merge commit master into feature/webapi-marble-tiled-output
KOKAProduktion 155b7cb
Add constrainDistance flag to showRectStreamlined
KOKAProduktion 3d91611
Implement basic map features retrieval (draft)
KOKAProduktion 61d3ebc
Merge remote-tracking branch 'origin/master' into feature/webapi-marb…
KOKAProduktion c89da64
Merge branch 'feature/webapi-marble-tiled-output' into feature/webapi…
KOKAProduktion 0960811
Don't constrain map distance on imageAction
KOKAProduktion eedb5ca
Add image attributions to image response and success code
KOKAProduktion 6b63860
Add simple OL implementation
KOKAProduktion 34e6283
Merge remote-tracking branch 'origin/master' into feature/webapi-marb…
KOKAProduktion 7de26a0
Complement previous commit
KOKAProduktion 4c0939f
Merge branch 'feature/webapi-marble-tiled-output' into feature/webapi…
KOKAProduktion f94269f
Implement map features retrieval by rect
KOKAProduktion e417194
Merge remote-tracking branch 'origin/master' into feature/webapi-marb…
KOKAProduktion c07a658
Merge remote-tracking branch 'origin/master' into feature/webapi-mapf…
KOKAProduktion d7ecd79
Add detailFactor to MapActionsController calls
KOKAProduktion ae22eef
Extend MapActionsController::features result
KOKAProduktion bcd605f
Complement API contract on NDB, VOR and Markers
KOKAProduktion a155597
Merge remote-tracking branch 'origin/master' into feature/webapi-mapf…
KOKAProduktion 6144c2a
Merge remote-tracking branch 'origin/master' into feature/webapi-marb…
KOKAProduktion 762dc69
Merge remote-tracking branch 'origin/master' into feature/webapi-mapf…
KOKAProduktion 3a615a8
Merge remote-tracking branch 'origin/master' into feature/webapi-marb…
KOKAProduktion b3330c5
Adapt renamed methods of MapPaintWidget
KOKAProduktion 27cd181
Adapt renamed methods of MapPaintWidget
KOKAProduktion 3968661
Add degree unit argument to get*ByRect conversions
KOKAProduktion 734e132
Adapt MapQuery changes
KOKAProduktion 9ea0429
Add map object id's to map features action result
KOKAProduktion 54c769a
Implement beasic get map feature by id action
KOKAProduktion cc4ec71
Merge branch 'feature/webapi-marble-tiled-output' into feature/webapi…
KOKAProduktion 77b3eaa
Add waypoints to map features result
KOKAProduktion 02356fb
Add wind direction and speed to sim info response
KOKAProduktion a01462f
Merge remote-tracking branch 'origin/master' into feature/webapi-mapf…
KOKAProduktion f9bdd7b
Fix merge issues/adapt changes
KOKAProduktion 0d902e3
Update OL build
KOKAProduktion 87e1650
Create initial ol-map plugin
KOKAProduktion b4fe9b2
Implement airport quicksearch via map toolbar
KOKAProduktion b37d8fc
Turn off aircraft following when quicksearching an airport
KOKAProduktion ac5e247
Trap main UI to respect ol-map plugin active state
KOKAProduktion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#848 Hi @albar965, I've started using MapPaintWidget::getPixmap() here but as far as i can see this hasn't been merged yet. Still won't exclude that I may have introduced the issue on the #772 and #776 PR's...
Should I check or investigate further?
Cheers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the merge the problem? Or reverting a change?
And there is still the issue with
getIls()
.I can simply release it the next days. It's an alpha/development version. People can expect issues. 🙂
Alex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, i don't think merging would solve the issue. At least I haven't run into it yet so i didn't fix anything in this PR. So maybe we shouldn't merge before we solve it, trying to avoid adding issues :)
Not retrieving ILS yet on this PR, I'm only that far for now:
Cheers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happens during paint in the marble widget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll investigate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Take your time.