Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amqp_ssl_socket_set_key_buffer returns 1 on success instead of AMQP_STATUS_OK (0) #723

Closed
nrgiii opened this issue Feb 21, 2022 · 0 comments · Fixed by #754
Closed

amqp_ssl_socket_set_key_buffer returns 1 on success instead of AMQP_STATUS_OK (0) #723

nrgiii opened this issue Feb 21, 2022 · 0 comments · Fixed by #754

Comments

@nrgiii
Copy link

nrgiii commented Feb 21, 2022

This function is documented to return AMQP_STATUS_OK (0) on success but in reality returns 1. The problem occurs because the code returns the SSL success indicator from SSL_CTX_use_RSAPrivateKey(), which is 1 instead of 0.
alanxz added a commit that referenced this issue Feb 2, 2023
@alanxz
fix: correct amqp_ssl_socket_set_key_buffer value
ad8cbb9 
Make amqp_ssl_socket_set_key_buffer return AMQP_STATUS_OK on success. It
currently returns the status of the underlying OpenSSL call, which isn't
correct.

Fixes: #723

Signed-off-by: GitHub <noreply@github.com>
@alanxz alanxz mentioned this issue Feb 2, 2023
Merged
alanxz added a commit that referenced this issue Feb 2, 2023
@alanxz
fix: correct amqp_ssl_socket_set_key_buffer value
6b18de0 
Make amqp_ssl_socket_set_key_buffer return AMQP_STATUS_OK on success. It
currently returns the status of the underlying OpenSSL call, which isn't
correct.

Fixes: #723

Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct amqp_ssl_socket_set_key_buffer value alanxz/rabbitmq-c
1 participant
@nrgiii