Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrupt librabbitmq.pc #599

Closed
talih0 opened this issue Jan 31, 2020 · 4 comments · Fixed by #601
Closed

corrupt librabbitmq.pc #599

talih0 opened this issue Jan 31, 2020 · 4 comments · Fixed by #601
Assignees

Comments

@talih0
Copy link

talih0 commented Jan 31, 2020

At the moment, the generated librabbitmq.pc file has an entry:

Libs.private: rt;-pthread
I believe it's supposed to be Libs.private: -lrt -lpthread

The redundant ";" will cause a compilation issue if the Libs.private flag is used.
This issue also exists on the ubuntu 16.04 packages.
Are you able to fix and backport the changes?

FYI, I'm trying to add your AMQP implementation into FFmpeg which is using pkg-config. At the moment I cannot compile without manually changing your package config file.

@alanxz alanxz self-assigned this Feb 1, 2020
@alanxz
Copy link
Owner

alanxz commented Feb 1, 2020

I can fix it in this repository at HEAD. I do not maintain older versions of rabbimq-c, nor do I maintain any of the packages included as a part of a distribution, thus I cannot help there.

@alanxz
Copy link
Owner

alanxz commented Feb 1, 2020

I'm also curious what FFmpeg needs with an pubsub client library?

@talih0
Copy link
Author

talih0 commented Feb 1, 2020

I'm also curious what FFmpeg needs with an pubsub client library?

Usually, if you want to stream video to multiple clients you'd have to use a separate server like Nginx. FFmpeg is just a client that sends data to the server (An alternative is to use multicast)
Here, the idea is that you could use RabbitMQ to distribute the video instead.

By the way, you can already use a brokerless pub-sub via ZeroMQ on FFmpeg:
FFmpeg/FFmpeg@ef43a4d

@talih0
Copy link
Author

talih0 commented Feb 1, 2020

I can fix it in this repository at HEAD. I do not maintain older versions of rabbimq-c, nor do I maintain any of the packages included as a part of a distribution, thus I cannot help there.

ok, thanks

talih0 added a commit to talih0/rabbitmq-c that referenced this issue Feb 18, 2020
Fixes alanxz#599

Private lib entries are currently separated by semicolon.
Replace semicolon by space and add -l prefix to libs.

Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
alanxz pushed a commit that referenced this issue Feb 20, 2020
Fixes #599

Private lib entries are currently separated by semicolon.
Replace semicolon by space and add -l prefix to libs.

Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants