Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump express-jwt from 6.1.1 to 7.5.0 #690

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 25, 2022

Bumps express-jwt from 6.1.1 to 7.5.0.

Changelog

Sourced from express-jwt's changelog.

7.5.0 - 2022-04-25

7.4.3 - 2022-04-21

7.4.2 - 2022-04-20

7.4.1 - 2022-04-20

7.4.0 - 2022-04-20

7.3.0 - 2022-04-20

7.2.0 - 2022-04-20

7.1.0 - 2022-04-20

7.0.0 - 2022-04-20

6.1.2 - 2022-04-20

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Apr 25, 2022
@dfellis
Copy link
Member

dfellis commented Apr 26, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/express-jwt-7.5.0 branch from 0a15046 to 5258f7e Compare April 26, 2022 00:04
@dfellis
Copy link
Member

dfellis commented Apr 26, 2022

This PR is blocked on auth0/node-jwks-rsa#297 being merged and we upgrade both of those simultaneously.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/express-jwt-7.5.0 branch 2 times, most recently from 7368329 to b11573b Compare April 26, 2022 18:58
@dfellis dfellis force-pushed the dependabot/npm_and_yarn/express-jwt-7.5.0 branch from 305b5c5 to 1042cda Compare April 26, 2022 20:48
@dfellis
Copy link
Member

dfellis commented Apr 26, 2022

So, putting this PR on hold for now because it blew up staging. It appears the req.user type has changed, too, and our dashboard goes into an infinite loop of errors because of it.

We need to wait for @types/express-jwt to be updated, too, to get this PR over the line.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 30, 2022

A newer version of express-jwt exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@dfellis
Copy link
Member

dfellis commented Jun 28, 2022

Attempted to tackle this again, but stuck on the Request type being incorrect, also it looks like express-jwt@7.x no longer has the req.user type, but req.auth so I am weary of upgrading without type safety here and opened an issue: auth0/express-jwt#298

@dfellis dfellis force-pushed the dependabot/npm_and_yarn/express-jwt-7.5.0 branch from 1042cda to 570ce0f Compare June 28, 2022 16:34
@dfellis
Copy link
Member

dfellis commented Nov 16, 2022

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 16, 2022

Looks like express-jwt is updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Nov 16, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/express-jwt-7.5.0 branch November 16, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants