Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to specifying a custom port to run the WebSocket on (Closes #61) #68

Merged
merged 5 commits into from
Apr 30, 2017
Merged

Conversation

alallier
Copy link
Owner

@alallier alallier commented Apr 16, 2017

(closes #61)

…js. This may also help reduce confusion when someone looks at the source code
…tion. Check to see if the parameter is a number, if it is configure reload to create and connect to a websocket running on that port, otherwise do the default (use the servers port, from the server being passed).
@alallier alallier changed the title Added the ability to specifying a custom port to run the WebSocket On (Closes #61) Added the ability to specifying a custom port to run the WebSocket on (Closes #61) Apr 16, 2017
@AckerApple
Copy link

I have released my pull request as a stand alone NPM package: ack-reload

I solved the issue of port specification by offering a stand alone server free of express:

https://www.npmjs.com/package/ack-reload#stand-alone-example

I also added an option for --html5Mode that reloads code but also always serves the index.html root app. Plays great with html 5 based routing.

I'll leave ya'll alone. Just wanted to make you aware of my npm package, that does the reload package but with less dependencies and more flexibility.

@alallier alallier added this to the v2.0.0 milestone Apr 27, 2017
@alallier alallier changed the base branch from master to v2.0.0 April 30, 2017 18:01
@alallier alallier merged commit 017f5b8 into alallier:v2.0.0 Apr 30, 2017
@alallier alallier deleted the socketConfig branch April 30, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants