Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency commander to v4 #220

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 1, 2019

This PR contains the following updates:

Package Type Update Change
commander dependencies major ~3.0.0 -> ~4.1.0

Release Notes

tj/commander.js

v4.1.0

Compare Source

Added
  • two routines to change how option values are handled, and eliminate name clashes with command properties ([#​933][#​1102])
    • see storeOptionsAsProperties and passCommandToAction in README
  • .parseAsync to use instead of .parse if supply async action handlers ([#​806][#​1118])
Fixed
  • Remove trailing blanks from wrapped help text ([#​1096])
Changed
  • update dependencies
  • extend security coverage for Commander 2.x to 2020-02-03
  • improvements to README
  • improvements to TypeScript definition documentation
  • move old versions out of main CHANGELOG
  • removed explicit use of ts-node in tests

v4.0.1

Compare Source

Fixed
  • display help when requested, even if there are missing required options ([#​1091])

v4.0.0

Compare Source

Added
  • automatically wrap and indent help descriptions for options and commands ([#​1051])
  • .exitOverride() allows override of calls to process.exit for additional error handling and to keep program running ([#​1040])
  • support for declaring required options with .requiredOptions() ([#​1071])
  • GitHub Actions support ([#​1027])
  • translation links in README
Changed
  • dev: switch tests from Sinon+Should to Jest with major rewrite of tests ([#​1035])
  • call default subcommand even when there are unknown options ([#​1047])
  • Breaking Commander is only officially supported on Node 8 and above, and requires Node 6 ([#​1053])
Fixed
  • Breaking keep command object out of program.args when action handler called ([#​1048])
    • also, action handler now passed array of unknown arguments
  • complain about unknown options when program argument supplied and action handler ([#​1049])
    • this changes parameters to command:* event to include unknown arguments
  • removed deprecated customFds option from call to child_process.spawn ([#​1052])
  • rework TypeScript declarations to bring all types into imported namespace ([#​1081])
Migration Tips
Testing for no arguments

If you were previously using code like:

if (!program.args.length) ...

a partial replacement is:

if (program.rawArgs.length < 3) ...

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the renovate label Nov 1, 2019
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #220   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         131    131           
=====================================
  Hits          131    131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e744a7d...4e2c0e3. Read the comment docs.

@alallier alallier merged commit 028c763 into master Jan 13, 2020
@alallier alallier deleted the renovate/commander-4.x branch January 13, 2020 21:00
alallier added a commit that referenced this pull request Jan 13, 2020
------------------

* Migrated CI to GitHub Actions - See: #222
* Moved sample app to a new project - See: #229
* Updated nyc from 14.1.1 to 15.0.0 - See: #224
* Updated sinon from 7.5.0 to 8.0.4 - See: #225
* Updated mocha from 6.2.2 to 7.0.0 - See: #226
* Updated commander from ~3.0.0 to ~4.1.0 - See: #220
* Removed tree-kill dependency - See: #223
@alallier alallier mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants