Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing document: reload version in sample app #210

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

alallier
Copy link
Owner

@alallier alallier commented Oct 6, 2019

Add line to contributing document to make sure the reload version in the sample app is incremented

@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #210   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         131    131           
=====================================
  Hits          131    131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3018ca0...b1d532b. Read the comment docs.

@alallier alallier merged commit 35f1a7a into master Oct 6, 2019
@alallier alallier deleted the updateContributing branch October 6, 2019 18:21
alallier added a commit that referenced this pull request Oct 6, 2019
------------------

* Updated express sample app's body-parser from 1.18.3 to 1.19.0 - See: #193
* Updated ws from ~6.2.1 to ~7.1.0 - See: #194
* Updated nyc from 14.0.0 to 14.1.1 - See: #195
* Updated serve-static from ~1.13.2 to ~1.14.0 - See: #196
* Updated codecov from 3.3.0 to 3.6.1 - See: #197
* Updated express in reload and sample from 4.16.4 to 4.17.1 - See: #198
* Updated mocha from 6.1.4 to 6.2.1 - See: #203
* Updated sinon from 7.3.2 to 7.5.0 - See: #204
* Updated commander from ~2.20.0 to ~3.0.0 - See: #205
* Updated standard from 12.0.1 to 14.3.1 - See: #206
* Use package.json files instead of `.npmignore`. See: #209
* Update CONTRIBUTING.md file for collaborators to ensure the sample app's reload version matches reload upstream. See: #210
@alallier alallier mentioned this pull request Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant