Version 3.0.0 #170
Merged
Version 3.0.0 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed deprecated parameters
* Updates dependencies
* Reload now returns a promise
* Functions in the return API also return promises
* Reload returns errors in promises
* Added unit tests.
* Added coverage analyzer
* Coverage 100% on `reload.js` file
* `startWebSocketServer` is the return API is not defined if the WebSocket wait option is not used
|
In the readme, it states to push a script tag down to the client as follows: <script src="/reload/reload.js"></script>That said, it isn't too clear that "/reload/reload.js" is a route that reload sets up in the express app. |
…ates * Added support for P12/PFX HTTPS files * Added forceWss option which forces the client to connect over `wss` even when the window is `https`
|
Hi! Any progress with this? Do you have any planned date for releasing 3.0.0? |
|
@meszaros-lajos-gyorgy sorry this is taking so long, I just have to make a couple of tweaks and then get it out. I'll see if I can get it out in the next two weeks |
|
Thank you! |
…ted this new logic with unit tests.
Added two new tests to test that the `startWebSocketServer` function is only returned when the option is enabled
|
@meszaros-lajos-gyorgy in case you missed this. This is now merged and published to npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.0.0
Consult Migration Guide for help with updating from Version 2.x to 3.x
Breaking/Removed
Breaking/Added
closerServerstartWebSocketServerAdded
reload.jsfilenpm ci installfor CI #158)Changed
Closes the following issues:
npm ci installfor CI #158 (Closes Investigate/implementnpm ci installfor CI #158)