Added socket server wait to start option #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low users to delay start of opening the WebSocket. This allows for reload to be used in a more async environment. Where there can be time inbetween requiring reload and starting the server
|
I introduced promises into my ack-reload fork and after reviewing the provided information for this issue, I think it would have been the better way to go. As I see it reload just fires up when called and has no callback or event chaining. I feel this is why I made the choice to return a Promise. This delay business does not look like an extra well thought out approach.. I could totally be wrong |
|
Might want to consider adding an examples folder to show how different reload configurations should look, this configuration could use an example. Ended up opening issue #131 for this. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the socket server creation to wait. This is useful for when there are are other events that happen inbetween requiring reload and start the HTTP server in an express app.
As well as ideally allowing the app initialization and socket server initialization to happen in two different spots, like requested in #67.
Note: I was quick to think we didn't need this when solving #56 with #104 but some people will need their socket server creation to wait. This will allow for that.