Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistence.TCK: Add SnapshotStore SaveSnapshot spec #7335

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Persistence.TCK: Add SnapshotStore SaveSnapshot spec #7335

merged 2 commits into from
Sep 4, 2024

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Sep 4, 2024 •
edited
Loading

Changes

Add new optional spec for Akka.Persistence.TCK

  • Spec for saving snapshot with the same SequenceNr
  • (Optional) Data integrity spec for concurrent saves
  • Data integrity spec is an opt-in spec, to turn it on, override SupportsConcurrentSaves to return true.

@Arkatufus
Copy link
Contributor Author

Arkatufus commented Sep 4, 2024 •
edited
Loading

This PR CI/CD will fail until #7334 is merged

@Arkatufus Arkatufus mentioned this pull request Sep 4, 2024
Merged
@Arkatufus Arkatufus enabled auto-merge (squash) September 4, 2024 17:47
@Aaronontheweb Aaronontheweb added this to the 1.5.28 milestone Sep 4, 2024
Aaronontheweb
Aaronontheweb approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus merged commit cfd25ef into akkadotnet:dev Sep 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-persistence
Projects
None yet
Milestone
1.5.28
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb