Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed ClusterClientDiscoverySpec #7322

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fixed ClusterClientDiscoverySpec #7322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ib/cluster/Akka.Cluster.Tools.Tests.MultiNode/ClusterClient/ClusterClientDiscoverySpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ protected ClusterClientDiscoverySpec(ClusterClientDiscoverySpecConfig config)
_config = config;
}

protected override int InitialParticipantsValueFactory => 3;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value should be set to 4, which the test will do by default. With a value of 3 it's possible that the RoleName("third") will start up late and hit a bunch of barriers late, causing the coordinator node to crash.


private void Join(RoleName from, RoleName to)
{
RunOn(() =>
Expand Down