Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlsoTo downstream failure propagation support #7301

Merged

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Jul 24, 2024

Fixes #7269

Changes

Add some new API for AlsoTo that allows users to opt-in to propagate downstream failures to its parent stream. If any flow/stage failed downstream of the AlsoTo flow, it will also cancel the parent stream with the same cause.

The default behavior will still ignore any cancellation/failures from downstream stages/flows

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably make this enabled by default - since that's what I'd expect if I were an end-user.

@Arkatufus
Copy link
Contributor Author

Arkatufus commented Jul 25, 2024

That would be a breaking change for existing implementation

Talked to Aaron about this offline, we decide that the correct behavior should be the default, even when it is a breaking change.

After some deliberation, the old behavior actually have a purpose, we're keeping the old behavior.

@Arkatufus
Copy link
Contributor Author

Done, failure propagation is the default behavior now

@Aaronontheweb Aaronontheweb merged commit 6b6afe4 into akkadotnet:dev Jul 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Akka Stream AlsoTo may not be failing graph when its sink throws exception
2 participants