Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka.Cluster.Tools.Singleton: migrate SingletonManager to using switch statements #7296

Merged

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Jul 23, 2024

Changes

For readability and safety reasons, when it comes to reasoning about how branching logic is supposed to work. Doesn't make any other substantive changes.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

For readability and safety reasons, when it comes to reasoning about how branching logic is supposed to work
@Aaronontheweb Aaronontheweb changed the title Akka.Cluster.Tools.Singleton / Akka.Cluster.Sharding: resolve duplicate shards issue Akka.Cluster.Tools.Singleton: migrate SingletonManager to using switch statements Jul 23, 2024
@Aaronontheweb Aaronontheweb added the code-style Code styling and readability improvements. label Jul 23, 2024
@Aaronontheweb Aaronontheweb added this to the 1.5.27 milestone Jul 23, 2024
@Aaronontheweb Aaronontheweb marked this pull request as ready for review July 23, 2024 22:11
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) July 23, 2024 22:11
@Aaronontheweb Aaronontheweb merged commit f4501e8 into akkadotnet:dev Jul 23, 2024
9 of 11 checks passed
@Aaronontheweb Aaronontheweb deleted the fix-6973-duplicate-shards branch July 23, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-cluster-tools code-style Code styling and readability improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant