Akka.Cluster.Sharding: enable prefer-oldest by default on Replicator
#7290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jul 22, 2024
| @@ -297,7 +297,7 @@ public sealed class StartProxy : INoSerializationVerificationNeeded | |||
| }); | |||
| } | |||
|
|
|||
| private ReplicatorSettings GetReplicatorSettings(ClusterShardingSettings shardingSettings) | |||
| internal static ReplicatorSettings GetReplicatorSettings(ClusterShardingSettings shardingSettings) | |||
There was a problem hiding this comment.
Made this internal in order to make it easy to test the real ReplicatorSettings that we're passing into DData - straight from the source.
| // only populated when remember-entities is enabled | ||
| replicatorSettings.DurableKeys.Should().BeEmpty(); | ||
| replicatorSettings.MaxDeltaElements.Should().Be(5); | ||
| replicatorSettings.PreferOldest.Should().BeTrue(); |
There was a problem hiding this comment.
Detect whether or not PreferOldest is enabled.
| @@ -207,6 +207,9 @@ akka.cluster.sharding { | |||
| distributed-data { | |||
| # minCap parameter to MajorityWrite and MajorityRead consistency level. | |||
| majority-min-cap = 5 | |||
|
|
|||
| # ShardCoordinator is singleton running on oldest | |||
| prefer-oldest = on | |||
There was a problem hiding this comment.
prefer-oldest should have been enabled for the DDataShardCoordinator when #5146 was originally introduced, but I overlooked it. This should play a key factor in #6973 - where LWWRegister data from the DDataShardCoordinator is going missing when the coordinator is pushing updates as it's exiting the cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Partially resolves #6973 - this change should have been made as part of #5146 originally
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):