Revert singleton app version #7287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jul 23, 2024
| @@ -353,9 +353,8 @@ namespace Akka.Cluster.Tools.Singleton | |||
| } | |||
| public sealed class ClusterSingletonManagerSettings : Akka.Actor.INoSerializationVerificationNeeded | |||
| { | |||
| public ClusterSingletonManagerSettings(string singletonName, string role, System.TimeSpan removalMargin, System.TimeSpan handOverRetryInterval, bool considerAppVersion) { } | |||
There was a problem hiding this comment.
Do we have to keep these old API signatures in order to preserve binary compatibility @Arkatufus ?
There was a problem hiding this comment.
we do, I think I missed it
…eb/akka.net into revert-singleton-app-version
4 tasks
# Conflicts: # src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonProxy.cs # src/contrib/cluster/Akka.Cluster.Tools/Singleton/MemberAgeOrdering.cs # src/contrib/cluster/Akka.Cluster.Tools/Singleton/OldestChangedBuffer.cs
|
Not needed anymore, feature was retro-actively removed by #7297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Correct solution to fixing #7196 and replaces #7197
Definitely a breaking change but the current functionality is both broken and dangerous.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
AppVersionjoins cluster #7197