Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide minSequenceNr for snapshot deletion #3641

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

ismaelhamed
Copy link
Member

Port #25590

var deleteTo = m.ToSequenceNr - 1;
var deleteFrom = Math.Max(0, deleteTo - Settings.TunningParameters.KeepNrOfBatches * Settings.TunningParameters.SnapshotAfter);
Log.Debug("PersistentShard messages to [{0}] deleted successfully. Deleting snapshots from [{1}] to [{2}]", m.ToSequenceNr, deleteFrom, deleteTo);
DeleteSnapshots(new SnapshotSelectionCriteria(deleteTo, DateTime.MaxValue, deleteFrom));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxTimeStamp is not required in the JVM. Are we missing a SnapshotSelectionCriteria overload here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ismaelhamed I think so - mind submitting a separate PR for that?

@Aaronontheweb
Copy link
Member

For some reason CI never ran on this branch.... No idea why

@Aaronontheweb
Copy link
Member

Ah, old commit date - September 29th.

@Aaronontheweb Aaronontheweb added this to the 1.3.11 milestone Nov 5, 2018
@Aaronontheweb Aaronontheweb self-assigned this Nov 29, 2018
@Aaronontheweb Aaronontheweb merged commit 805647c into akkadotnet:dev Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants