Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test Akka.FSharp.System.create with extensions #3407

Merged
merged 4 commits into from
May 17, 2018

Conversation

aaronpalmer
Copy link
Contributor

Add a unit test to demonstrate a bug with Akka.FSharp.System.create when creating with a configuration that has akka.extensions specified.

…hen creating with a configuration that has akka.extensions specified.
…hen creating with a configuration that has akka.extensions specified.
@AaronEshbach
Copy link

AaronEshbach commented Apr 19, 2018

I did a little research, and there is a conflicting serializer ID. Both the Cluster Tools DistributedPubSubMessageSerializer and the FSharp ExprSerializer use the same identifier, 9. I think changing the ID for one of these serializers would fix this unit test. There should probably be a unit test to verify that all built-in serializers can be loaded togehter (i.e. they have unique IDs).

@Danthar Danthar merged commit 53e0e06 into akkadotnet:dev May 17, 2018
@Danthar
Copy link
Member

Danthar commented May 17, 2018

Thx for your contribution

@Aaronontheweb Aaronontheweb added this to the 1.3.8 milestone Jun 4, 2018
@Aaronontheweb
Copy link
Member

@AaronEshbach did that issue with the colliding serializer IDs get resolved? Or should we file a new issue for that?

@AaronEshbach
Copy link

We tested Akka.FSharp with Akka.Cluster.Tools at version 1.3.8, and the issue appears to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants