Akka.IO bug fixes #3206
Merged
Akka.IO bug fixes #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Dec 3, 2017
| try | ||
| { | ||
| _connection.Socket.Blocking = true; | ||
| return _connection.Socket.Send(data.Buffers); |
There was a problem hiding this comment.
Guys. Does it mean that connection after that will be "blocking" forever ?
There was a problem hiding this comment.
No, only for this operation - on the line below we turn the socket back to non-blocking afterwards in the finally block. Unless the semantics of how this is implemented by the CLR are different than expected...
| { | ||
| var bytesWritten = _connection.Socket.Send(data.Buffers); | ||
| if (_connection.traceLogging) | ||
| _connection.Log.Debug("Wrote [{0}] bytes to channel", bytesWritten); | ||
| if (bytesWritten < data.Count) | ||
| { | ||
| // we weren't able to write all bytes from the buffer, so we need to try again later | ||
| return WriteToChannel(data.Slice(bytesWritten)); | ||
| data = data.Slice(bytesWritten); |
This was referenced Dec 3, 2017
Horusiath
added a commit
to Horusiath/akka.net
that referenced
this pull request
Dec 4, 2017
* DoWrite changed from recursive function to loop * workaround for WSAEWOULDBLOCK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 bugs:
SocketError.WouldBlock. According to winsock docs, in this case we should try to make a send later. However we could also switch flag toSocket.Blocking = trueand fallback to blocking send. This is not ideal, but for sure it's better than the current state.